Don't capture errors estimating time max spread #7912
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
remove-catch-in-time-utils
branch
4 times, most recently
from
291d714 to
98dd6a7
Compare
In the time utility functions errors were captured to, it seems, handle syntax errors and out-of-range errors, but this also capture hard errors like out-of-memory and continued to execute, which can cause panics as a result of error stack being exhausted. This commit removes the capture and allow the error to propagate to callers, including out-of-range errors and syntax errors. The `PG_TRY` in `estimate_max_spread_var` was added in commit 9a29f04 but it is not clear in that commit why it was needed but removing it does not cause any test failures.
mkindahl
force-pushed
the
remove-catch-in-time-utils
branch
from
98dd6a7 to
a62abbb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7912 +/- ##
==========================================
+ Coverage 80.06% 81.91% +1.84%
==========================================
Files 190 249 +59
Lines 37181 46129 +8948
Branches 9450 11563 +2113
==========================================
+ Hits 29770 37787 +8017
- Misses 2997 3785 +788
- Partials 4414 4557 +143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the time utility functions errors were captured to, it seems, handle syntax errors and out-of-range errors, but this also capture hard errors like out-of-memory and continued to execute, which can cause panics as a result of error stack being exhausted.
This commit removes the capture and allow the error to propagate to callers, including out-of-range errors and syntax errors.
The
PG_TRYinestimate_max_spread_varwas added in commit 9a29f04 but it is not clear in that commit why it was needed but removing it does not cause any test failures.