Skip to content

Add tests for defaults and generated column values #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mkindahl
Copy link
Member

@mkindahl mkindahl commented Nov 14, 2024

This adds basic tests for generated columns and columns with default values for tables using the Hypercore TAM.

Disable-check: force-changelog-file

@mkindahl mkindahl self-assigned this Nov 14, 2024
@mkindahl mkindahl marked this pull request as ready for review November 14, 2024 08:34
@mkindahl mkindahl force-pushed the hypercore-generated-and-default branch from 248c58d to 9a30ddd Compare November 14, 2024 11:34
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (59f50f2) to head (ee522aa).
Report is 1009 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7441      +/-   ##
==========================================
+ Coverage   80.06%   82.10%   +2.04%     
==========================================
  Files         190      230      +40     
  Lines       37181    43095    +5914     
  Branches     9450    10830    +1380     
==========================================
+ Hits        29770    35385    +5615     
- Misses       2997     3396     +399     
+ Partials     4414     4314     -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkindahl mkindahl force-pushed the hypercore-generated-and-default branch from 9a30ddd to 7980e28 Compare November 14, 2024 16:41
@mkindahl mkindahl force-pushed the hypercore-generated-and-default branch from 7980e28 to dd48a15 Compare November 19, 2024 07:40
@mkindahl mkindahl enabled auto-merge (rebase) November 19, 2024 07:40
@mkindahl mkindahl force-pushed the hypercore-generated-and-default branch from dd48a15 to b2716cf Compare November 19, 2024 08:03
@mkindahl mkindahl disabled auto-merge November 19, 2024 14:21
This adds basic tests for generated columns and columns with default
values.
@mkindahl mkindahl force-pushed the hypercore-generated-and-default branch from b2716cf to ee522aa Compare November 20, 2024 12:59
@mkindahl mkindahl enabled auto-merge (rebase) November 20, 2024 13:00
@mkindahl mkindahl merged commit 4261541 into timescale:main Nov 20, 2024
50 checks passed
@mkindahl mkindahl deleted the hypercore-generated-and-default branch November 20, 2024 13:56
@akuzm akuzm added the released-2.18.0 Released in 2.18.0 label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants