Skip to content

Simplify dealing with attnos during decompression #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

antekresic
Copy link
Member

@antekresic antekresic commented Oct 1, 2024

We fetch key column attribute numbers from indexes on uncompressed chunks. These should not contain
system attribute numbers so there is no point in
adding/subtracting FirstLowInvalidHeapAttributeNumber.

Disable-check: force-changelog-file

We fetch key column attribute numbers from indexes
on uncompressed chunks. These should not contain
system attribute numbers so there is no point in
adding/subtracting FirstLowInvalidHeapAttributeNumber.
@antekresic antekresic requested a review from svenklemm October 1, 2024 13:53
@antekresic antekresic self-assigned this Oct 1, 2024
@antekresic antekresic marked this pull request as ready for review October 1, 2024 13:54
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (59f50f2) to head (e541dd8).
Report is 1009 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/compression/compression_dml.c 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7311      +/-   ##
==========================================
+ Coverage   80.06%   82.14%   +2.07%     
==========================================
  Files         190      217      +27     
  Lines       37181    38864    +1683     
  Branches     9450    10025     +575     
==========================================
+ Hits        29770    31924    +2154     
+ Misses       2997     2959      -38     
+ Partials     4414     3981     -433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antekresic antekresic merged commit 4a66478 into timescale:main Oct 1, 2024
44 of 46 checks passed
@akuzm akuzm added the released-2.17.0 Released in 2.17.0 label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor released-2.17.0 Released in 2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants