Add compression flush callback #7298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7298 +/- ##
===========================================
+ Coverage 80.06% 92.26% +12.19%
===========================================
Files 190 205 +15
Lines 37181 38567 +1386
Branches 9450 9999 +549
===========================================
+ Hits 29770 35583 +5813
+ Misses 2997 2984 -13
+ Partials 4414 0 -4414 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+1332
to
+1333
| row_compressor->on_flush(row_compressor, | ||
| row_compressor->rows_compressed_into_current_value); |
There was a problem hiding this comment.
I assume for the following PRs we'll have some tests for covering it, right?
There was a problem hiding this comment.
yes, there is no code coverage now because nothing is using it. But the table access method will be using it.
fabriziomello
approved these changes
Sep 24, 2024
erimatnor
force-pushed
the
compression-expose-functions
branch
from
54dad24 to
e2289a1
Compare
Add the ability to define a callback function that gets called every time a new segment is flushed during compression. The callback can be used to report compression progress. Also expose the function to create a tuple sort state for compression.
erimatnor
force-pushed
the
compression-expose-functions
branch
from
e2289a1 to
39a7bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to define a callback function that gets called every time a new segment is flushed during compression. The callback can be used to report compression progress.
Also expose the function to create a tuple sort state for compression.
Disable-check: force-changelog-file