Fix stale code in Ensure #6997
Merged
Fix stale code in Ensure #6997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make Ensure use all its argument even in debug mode, so that these things are easier to notice.
antekresic
reviewed
Jun 4, 2024
antekresic
approved these changes
Jun 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6997 +/- ##
==========================================
+ Coverage 80.06% 81.76% +1.69%
==========================================
Files 190 199 +9
Lines 37181 37013 -168
Branches 9450 9671 +221
==========================================
+ Hits 29770 30262 +492
+ Misses 2997 2864 -133
+ Partials 4414 3887 -527 ☔ View full report in Codecov by Sentry. |
| #define Ensure(COND, FMT, ...) \ | ||
| do \ | ||
| { \ | ||
| if (unlikely(!(COND))) \ | ||
| { \ | ||
| Assert(false); \ |
There was a problem hiding this comment.
Is this correct? I mean if the condition is false it is intended to ereport on release builds. Or am I missing something?
There was a problem hiding this comment.
Assert(false) will only be active in debug builds and trigger coredump, on prod builds you will get the error
svenklemm
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make Ensure use all its argument even in debug mode, so that these things are easier to notice.
The problem was introduced by #6838
Disable-check: force-changelog-file