This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Allow calling init seperately #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This allows generating the init function from class names alone
The command otherwise failed when used with cargo workspaces
This is e.g. useful for conditional compilation with features
|
Ping! Will this PR get reviewed? |
|
@konstin I'm not qualified to approve this change, but I can tell you that we're working on a number of internal refactors, so that is slowing us down a bit |
|
Well in this case I'd suggest to merge this before doing the refactorings as there will likely be merge conflicts otherwise. The diff is also only +70 -5 with no unsafe code touched, so it shouldn't take longer than ten minutes to review. |
|
A bit late, but I'm comfortable with this change. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows calling
codegen_init!separately, which is needed to build a custom derive for helix. The other commit is a small change to make helix_runtime agnostic to cargo workspaces.