Skip to content

*: remove redundant log #9291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

*: remove redundant log #9291

merged 2 commits into from
May 7, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 7, 2025

What problem does this PR solve?

Issue Number: ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented May 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. labels May 7, 2025
@rleungx rleungx marked this pull request as ready for review May 7, 2025 05:25
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels May 7, 2025
@rleungx rleungx requested review from JmPotato and lhy1024 May 7, 2025 05:27
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 7, 2025
Copy link
Contributor

ti-chi-bot bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 7, 2025
Copy link
Contributor

ti-chi-bot bot commented May 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-07 05:56:25.763440631 +0000 UTC m=+421032.946343889: ☑️ agreed by lhy1024.
  • 2025-05-07 06:16:40.288783849 +0000 UTC m=+422247.471687109: ☑️ agreed by JmPotato.

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.08%. Comparing base (7c3b9a3) to head (49cda4e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9291      +/-   ##
==========================================
+ Coverage   75.96%   76.08%   +0.11%     
==========================================
  Files         472      472              
  Lines       73249    73259      +10     
==========================================
+ Hits        55646    55737      +91     
+ Misses      14131    14065      -66     
+ Partials     3472     3457      -15     
Flag Coverage Δ
unittests 76.08% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit ab7efa6 into tikv:master May 7, 2025
35 of 36 checks passed
@rleungx rleungx deleted the unnecessary-log branch May 7, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants