Skip to content

tso: fix tso proxy error propagation (#9219) #9263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-6.5
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9219

What problem does this PR solve?

Issue Number: Close #9188

What is changed and how does it work?

The change fixes the problems outlined in #9188 (comment)

  • Don't block client stream on receiving next request and allow to return error from proxy
  • Allow to return proxy error to all clients served by the proxy error
  • Don't cancel proxy stream after original client stream is closed

Tested using the same way as reported in the issue and observe subsecond impact only now:

[ 67s ] thds: 64 tps: 2007.63 qps: 2007.63 (r/w/o: 0.00/2007.63/0.00) lat (ms,95%): 116.80 err/s: 0.00 reconn/s: 0.00
[ 68s ] thds: 64 tps: 1962.21 qps: 1962.21 (r/w/o: 0.00/1962.21/0.00) lat (ms,95%): 121.08 err/s: 0.00 reconn/s: 0.00
[ 69s ] thds: 64 tps: 1984.16 qps: 1984.16 (r/w/o: 0.00/1984.16/0.00) lat (ms,95%): 116.80 err/s: 0.00 reconn/s: 0.00
[ 70s ] thds: 64 tps: 504.00 qps: 504.00 (r/w/o: 0.00/504.00/0.00) lat (ms,95%): 646.19 err/s: 0.00 reconn/s: 0.00
[ 71s ] thds: 64 tps: 1607.99 qps: 1607.99 (r/w/o: 0.00/1607.99/0.00) lat (ms,95%): 125.52 err/s: 0.00 reconn/s: 0.00
[ 72s ] thds: 64 tps: 2010.98 qps: 2010.98 (r/w/o: 0.00/2010.98/0.00) lat (ms,95%): 116.80 err/s: 0.00 reconn/s: 0.00
[ 73s ] thds: 64 tps: 1965.68 qps: 1965.68 (r/w/o: 0.00/1965.68/0.00) lat (ms,95%): 123.28 err/s: 0.00 reconn/s: 0.00

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Apr 25, 2025
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2025
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci/build 53dc2c9 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants