Skip to content

merge_checker: use leader info to valid region #5655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Oct 31, 2022

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

Issue Number: Close #4399

What is changed and how does it work?

merge_checker: use leader info to valid region

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 31, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 31, 2022
@ti-chi-bot ti-chi-bot requested review from lhy1024 and rleungx October 31, 2022 14:13
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 75.66% // Head: 75.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0e6bd0c) compared to base (80f0d8c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5655      +/-   ##
==========================================
- Coverage   75.66%   75.66%   -0.01%     
==========================================
  Files         328      328              
  Lines       32566    32566              
==========================================
- Hits        24642    24640       -2     
+ Misses       5804     5799       -5     
- Partials     2120     2127       +7     
Flag Coverage Δ
unittests 75.66% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/checker/merge_checker.go 71.21% <100.00%> (+1.51%) ⬆️
pkg/dashboard/keyvisual/input/core.go 0.00% <0.00%> (-33.34%) ⬇️
server/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
pkg/metricutil/metricutil.go 82.75% <0.00%> (-6.90%) ⬇️
server/id/id.go 83.05% <0.00%> (-6.78%) ⬇️
server/schedule/labeler/labeler.go 76.77% <0.00%> (-2.59%) ⬇️
server/schedule/operator_controller.go 86.26% <0.00%> (-0.91%) ⬇️
server/schedule/checker/rule_checker.go 78.82% <0.00%> (-0.91%) ⬇️
server/cluster/cluster.go 82.31% <0.00%> (-0.54%) ⬇️
server/encryptionkm/key_manager.go 70.11% <0.00%> (-0.40%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2022
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 1, 2022
@nolouch
Copy link
Contributor Author

nolouch commented Nov 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e6bd0c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2022
@ti-chi-bot ti-chi-bot merged commit 5916a46 into tikv:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue
3 participants