Add disable_initial_exec_tls feature for jemalloc-ctl #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
reviewed
Jul 18, 2023
jemalloc-ctl/Cargo.toml
Outdated
| @@ -26,7 +26,7 @@ is-it-maintained-open-issues = { repository = "tikv/jemallocator" } | |||
| maintenance = { status = "actively-developed" } | |||
|
|
|||
| [dependencies] | |||
| tikv-jemalloc-sys = { path = "../jemalloc-sys", version = "0.5.0" } | |||
| tikv-jemalloc-sys = { path = "../jemalloc-sys", version = "0.5.0", default-features = false } | |||
There was a problem hiding this comment.
Why need to disable default features?
There was a problem hiding this comment.
I just followed Cargo.toml from jemallocator folder, maybe I should not disable it?
There was a problem hiding this comment.
Better keep it the old way, otherwise it becomes a broken change.
BusyJay
approved these changes
Jul 18, 2023
Signed-off-by: Likai Feng <[email protected]>
|
Aarch64 test has no machine from pingcap. |
|
@BusyJay Can you make a new release to crate.io? |
|
Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default feature of tikv-jemalloc-sys can cause error when using pyo3 with jemalloc. Add disable_initial_exec_tls feature for jemalloc-ctl to avoid tikv-jemalloc-sys's default feature.
PyO3/pyo3#678