Support RoutingAction__use_lane_ids_for_routing option for routing actions
#1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion::setRoutePoints
…y::requestAssignRoute
…ecification_for_waypoint.yaml
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…on_for_waypoints to RoutingAction.use_lane_level_specification_for_waypoints
…specification_for_waypoint.yaml
…modification.yaml
…oEntity::requestReplanRoute
HansRobo
changed the title
use_lane_level_specification_for_waypoints option for routing actions
HansRobo
added
the
bump minor
…or_application.cpp
HansRobo
changed the title
use_lane_level_specification_for_waypoints option for routing actions RoutingAction__use_lane_ids_for_routing option for routing actions
|
yamacir-kit
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
RoutingAction__use_lane_ids_for_routingto switch calling appropriate ADAPI.AcquirePositionAction.allow_goal_modificationintoRoutingAction__allow_goal_modificationto show supporting it inAssignRouteActionrequestAssignRouteandrequestAcquirePositionoverloads inEgoEntityplanoverloads and mark old one as deprecated to support dual ADAPI, inFieldOperatorApplicationDetails
Changes in functions of
EgoEntityandFieldOperatorApplication.References
https://github.com/tier4/sim_evaluation_tools/issues/525
Destructive Changes
Old type of
FieldOperatorApplication::planis now deprecated and will be deleted in the futureKnown Limitations
EgoEntity::requestReplanRoutedoes not supportRoutingAction__use_lane_ids_for_routingfor now. (But it does not break legacy behavior.)We should consider about manual-override simulation behavior when we modify this function.
So, I did not modify it because I think it is beyond scope of this pull-request.