Skip to content

Refactor/behavior_tree-1 #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2025
Merged

Refactor/behavior_tree-1 #1602

merged 6 commits into from
May 23, 2025

Conversation

takanotaiga
Copy link
Member

@takanotaiga takanotaiga commented May 21, 2025

Abstract

This pull request is a refactoring of the BehaviorTreePlugin proposed by ROBOTECH.

Background

N/A

Details

  • Changed unnecessarily public members to private.
  • Added trailing underscores to field names in ActionNode.
  • Changed the methods in behavior_tree.hpp to use trailing return types.

References

Destructive Changes

N/A

Known Limitations

N/A

@takanotaiga takanotaiga self-assigned this May 21, 2025
@takanotaiga takanotaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label May 21, 2025
Copy link

github-actions bot commented May 21, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Copy link

@takanotaiga takanotaiga marked this pull request as ready for review May 23, 2025 02:32
@takanotaiga takanotaiga requested a review from hakuturu583 May 23, 2025 02:32
@hakuturu583 hakuturu583 merged commit 6f370c3 into master May 23, 2025
19 checks passed
@github-actions github-actions bot deleted the refactor/behavior-tree-1 branch May 23, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants