Skip to content

fix push tag position #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

fix push tag position #1596

merged 2 commits into from
May 19, 2025

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented May 16, 2025

Description

Abstract

Fix wrong format in push tag in Docker.yaml.

Background

Docker images for traffic_simulator does not exist on GitHub container registry.

Details

In, #1535.
Push tags in Docker.yaml was wrong.

wrong

      - name: Build and push
        if: github.event_name == 'workflow_dispatch'
        uses: docker/[email protected]
        with:
          files: |
            ./docker-bake.hcl
          workdir: .
          set: |
            *.cache-to=type=gha,mode=max
            *.cache-from=type=gha
            *.tags=ghcr.io/tier4/scenario_simulator_v2:traffic_simulator_${{ matrix.rosdistro }}-${{ github.event.inputs.version }}
            *.tags=ghcr.io/tier4/scenario_simulator_v2:traffic_simulator-latest
            push: true
          targets: |
            traffic_simulator_${{ matrix.rosdistro }}

right

      - name: Build and push
        if: github.event_name == 'workflow_dispatch'
        uses: docker/[email protected]
        with:
          files: |
            ./docker-bake.hcl
          workdir: .
          set: |
            *.cache-to=type=gha,mode=max
            *.cache-from=type=gha
            *.tags=ghcr.io/tier4/scenario_simulator_v2:traffic_simulator_${{ matrix.rosdistro }}-${{ github.event.inputs.version }}
            *.tags=ghcr.io/tier4/scenario_simulator_v2:traffic_simulator-latest
          push: true
          targets: |
            traffic_simulator_${{ matrix.rosdistro }}

References

#1535

Destructive Changes

N/A

Known Limitations

N/A

Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 requested a review from takanotaiga May 16, 2025 06:12
@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label May 16, 2025
@hakuturu583 hakuturu583 marked this pull request as draft May 16, 2025 06:13
Copy link

github-actions bot commented May 16, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 marked this pull request as ready for review May 16, 2025 06:29
Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 marked this pull request as draft May 16, 2025 08:55
@hakuturu583 hakuturu583 marked this pull request as ready for review May 19, 2025 01:13
@hakuturu583 hakuturu583 self-assigned this May 19, 2025
@takanotaiga takanotaiga merged commit 780dcac into master May 19, 2025
9 checks passed
@github-actions github-actions bot deleted the fix/docker_push branch May 19, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants