Skip to content

Avoid link check error #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged

Avoid link check error #1591

merged 4 commits into from
May 12, 2025

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented May 9, 2025

Description

Abstract

To avoid link check errors, reduce max-concurrency, and trigger files

Background

Recently, link checks are failed due to rate limit of github

https://github.com/tier4/scenario_simulator_v2/actions/workflows/DocumentationLinkCheck.yaml

References

To test this pull-request, I added a test commit that changes markdown file.
The commit triggers the link check action and has no errors.
https://github.com/tier4/scenario_simulator_v2/actions/runs/14924888377/job/41927399418?pr=1591

Destructive Changes

None

Known Limitations

Due to this change, link check takes long time.

Copy link

github-actions bot commented May 9, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label May 9, 2025
@HansRobo HansRobo requested a review from hakuturu583 May 9, 2025 09:04
@HansRobo HansRobo marked this pull request as ready for review May 9, 2025 09:05
@hakuturu583 hakuturu583 merged commit b35d587 into master May 12, 2025
10 checks passed
@github-actions github-actions bot deleted the avoid-link-check-errors branch May 12, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants