CRAN check failure

[hadley]

https://cran.r-project.org/web/checks/check_results_haven.html

Version: 2.5.1 
Check: compiled code 
Result: WARN 
    File ‘haven/libs/haven.so’:
     Found ‘__sprintf_chk’, possibly from ‘sprintf’ (C)
     Objects: ‘readstat/spss/readstat_por.o’,
     ‘readstat/stata/readstat_dta_write.o’
    
    Compiled code should not call entry points which might terminate R nor
    write to stdout/stderr instead of to the console, nor use Fortran I/O
    nor system RNGs nor [v]sprintf.
    
    See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual. 
Flavors: [r-devel-linux-x86_64-debian-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/haven-00check.html), [r-devel-linux-x86_64-debian-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/haven-00check.html), [r-devel-linux-x86_64-fedora-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/haven-00check.html)

Version: 2.5.1 
Check: whether package can be installed 
Result: WARN 
    Found the following significant warnings:
     readstat/readstat_bits.h:10:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/readstat_bits.c:11:5: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/readstat_variable.c:5:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/readstat_variable.c:8:25: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/sas/../readstat_bits.h:10:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/sas/ieee.c:19:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/sas/ieee.c:99:5: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/sas/readstat_sas.c:123:15: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/sas/readstat_xport_read.c:48:21: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/spss/readstat_por.h:34:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/spss/readstat_por.c:67:12: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/spss/readstat_por_write.c:170:25: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/spss/../readstat_bits.h:10:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
     readstat/stata/../readstat_bits.h:10:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
    See ‘/home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/haven.Rcheck/00install.out’ for details.
    * used C compiler: ‘gcc-12 (Debian 12.2.0-13) 12.2.0’
    * used C++ compiler: ‘g++-12 (Debian 12.2.0-13) 12.2.0’ 
Flavor: [r-devel-linux-x86_64-debian-gcc](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/haven-00check.html)

@lionel- can you remind me what we need to do for the "warning: function declaration isn’t a prototype" problem?

[lionel-]

All declarations like:

void fn();

Must be changed to:

void fn(void);

[hadley]

@lionel- I forgot that all these functions are from readstat. We don't really believe this change is necessary right, so it's hard to argue that readstat should make the change?

[lionel-]

yes that's what I think as well. The changes are not harmful but they force an obsolete style (or soon to be) into vendored libraries.

Maybe we could come up with a script that makes the necessary changes to the C signatures...

[hadley]

sprinf issue solved in WizardMac/ReadStat#292.

[gorcha]

It looks like the function prototype issue has also been fixed in WizardMac/ReadStat#295. I'm currently merging in the new ReadStat version, will see if it gets rid of all the warnings.

[hadley]

@gorcha do you want to manage the release? i.e. call usethis::use_release_issue() and then follow the check list up until the submit to CRAN step, where I'll take over?

[gorcha]

Hey @hadley sure thing, I'll think I'll just need you to run the revdepcheck::cloud_check() step.

[hadley]

@gaborcsardi oh yeah, good call.