OvmfPkg/PlatformDebugLibIoPort: Add check for MemDebugLogWrite #11239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is present for every call to `MemDebugLogWrite` but it is missing here. This may cause an unwanted write to the buffer, when the buffer's address is not null and MemDebug is disabled. Signed-off-by: Luigi Leonardi <[email protected]>
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
jyao1 and
kraxel
kraxel
approved these changes
Jun 30, 2025
|
This change is technically not needed (i.e. it's not a BUG) because the MemDebugLogNull implementation of MemDebugLogWrite() is a NOP. The only reason we added MemDebugLogEnabled() is it to allow DebugPrintMarker() to be optimized to bypass the string formatting. But, it doesn't hurt to add the extra call in DebugAssert() as well. Just FYI... |
|
Thanks for the information! I guess I have to change the commit message. I'll leave it up to the maintainers to decide whether or not to merge this. |
ardbiesheuvel
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is present for every call to
MemDebugLogWritebut it is missing here. This may cause an unwanted write to the buffer, when the buffer's address is not null and MemDebug is disabled.Description
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>