-
Notifications
You must be signed in to change notification settings - Fork 309
Upgrade jest to v30 #3175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade jest to v30 #3175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it might be difficult to add support for v30 without dropping v29, did you try that?
No, I don't. Do we really need that? |
I would like to hold off for major release to wait for |
Do we need modify workflows to run tests for each supported jest major versions? |
The current workflow is good. We just need one example app to stay on Jest 29 is good, for example we can use |
@ahnpnl Docs lint fails. I suggest two options:
|
That is expected. I think it’s better to revert the change. We only run prettier CLI on docs and workflow config while ESLint format differently. That will avoid making too many changes to this PR too |
Fixed
Fixed |
1c6507b
to
5537df1
Compare
@ahnpnl I won't fix any more conflicts. New ones every couple of hours. Fix it yourself when you have time. |
@ahnpnl when this could be merged? |
## Current Behavior Jest v30 is not supported. **Note**: this is currently awaiting for `jest-preset-angular` to support Jest v30: thymikee/jest-preset-angular#3175. ## Expected Behavior Jest v30 should be supported. ## Related Issue(s) Fixes #31778
Summary
Jest has been updated to version 30, and Node.js and TypeScript have been brought up to the minimum versions supported by the latest Jest release.
Jest now uses a new
unrs-resolver
, which don't have thepackageFilter
option. After reviewing the code, I couldn't find any usages ofngJestResolver
, so I removed it. Feel free to discuss.Test plan
Does this PR introduce a breaking change?
Other information
Resolves: #3152