Changes for release 1.2.0 (v1 release with fixes/improvements backported from v2) #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on for discrete case
…uto-handling with defaults)
… spaces and allow coefficient to be modified, adding an informative docstring (previous implementation was reasonable only for continuous action spaces) Adjust parametrisation to match procedural example in atari_sac_hl
… in NPG and TRPO * Parameter optim must not include the actor parameters (as they are updated via natural gradients that are computed internally) * Fix incorrect optimizer instantiation in high-level API
…to running the trainer, yet recently introduced parameter `reset_prior_to_run` of `run` suggested that it was optional. But it was not respected, because `__iter__` would always call `reset(reset_collectors=True, reset_buffer=False)` regardless. The parameter was removed; instead, the parameters of `run` now mirror the parameters of `reset`, and the implicit `reset` call in `__iter__` was removed. This aligns with upcoming changes in Tianshou v2.0.0.
responsible for creating the snapshot(s) on the original branch and then compare with results on a modified branch. Add writing of a log file for determinism tests.
Fix some broken tests that directly used the trainer's iterator instead of using run(): * test/continuous/test_ppo * test/continuous/test_td3
…QN, QRDQN, Rainbow)
* Require only core message equivalence (network parameter hashes)
for the test to pass
* Allow to ignore certain messages on a per-test level
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
- Coverage 85.28% 84.09% -1.19%
==========================================
Files 102 104 +2
Lines 9083 9327 +244
==========================================
+ Hits 7746 7844 +98
- Misses 1337 1483 +146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Slightly enhanced docstrings in collector
The mechanism introduced in v1.1.0 was completely revised:
- The `train_seed` and `test_seed` attributes were removed from `SamplingConfig`.
Instead, the seeds are derived from the seed defined in `ExperimentConfig`.
- Seed attributes of `EnvFactory` classes were removed.
Instead, seeds are passed to methods of `EnvFactory`.
Control validation enabling with global flag
Don't mutate incoming dict, don't load invalid fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See change log