Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this doesn't work with Node v0.12 - I've made attempts at fixing but out of my depth in C++ (willing to learn though!).
So it seems the first step would be to upgrade nan to 1.6 - this actually works great (with some deprecation warnings.)
The next problem was atomicops.h - in v8 3.27 (node v0.12 is on v8 3.28)
this was relocated to deps/v8/src/base, and then atomicops.h is expecting deps/v8.
So that's why extra paths are added to bindings.gyp.
Then I hit these errors:
And now I do not know what to do...
I notice scripts/preinstall.js performs some pre-processing on the flags definition file...
Maybe there's been a refactor of v8_flag_definitions.h ...
... help?