Refactor: drop es5-ext

[SukkaW]

es5-ext was introduced to WebSocket-Node in 2019 by #362 to address #360. However:

• Use es5-ext/global as a more robust way to resolve browser's window object (global this) #362 doesn't really fix the webpack bundling issue.
  • es5-ext/global still prefers exactly the same (function() { return this; })(); approach over window or self, the approach which Fix Webpack global scope issue #360 was trying to get rid of in the first place, see:
  • https://github.com/medikoo/es5-ext/blob/f76b03d8c49ce4871f37f428c0e1d3ee6637fcc4/global.js#L7-L8
• es5-ext is a huge and heavy dependency.
  • It will introduce extra 643 KiB to the node_modules folder.
  • It is not really being used by the majority of the user base (where they are running this library on Node.js). And even for those who are bundling this library with webpack/rollup/etc for running in the browser, es5-ext/global is still unnecessarily heavy.

The PR removes es5-ext, and instead uses the globalThis polyfill implementation from core-js.

[gemini-code-assist]

Summary of Changes

Hello @SukkaW, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've refactored the WebSocket-Node library to remove the es5-ext dependency, which was causing unnecessary bloat and not effectively solving its intended problem. My changes replace the es5-ext-based globalThis polyfill with a more lightweight and effective solution derived from core-js. This significantly reduces the library's footprint and improves its overall efficiency, especially for browser-based usage.

Highlights

• Dependency Removal: I have removed the es5-ext package from the project's dependencies. This package was identified as a significant contributor to the node_modules size (adding 643 KiB) and was not effectively addressing the webpack bundling issues it was intended to solve.
• Global Object Polyfill Refactor: The globalThis polyfill logic in lib/browser.js has been updated. Instead of relying on es5-ext/global, I've implemented a custom, more efficient, and robust polyfill strategy inspired by core-js. This ensures proper global object detection across various environments without the overhead of the es5-ext dependency.
• Performance and Efficiency Improvement: These changes lead to a lighter and more efficient library. By removing a heavy and problematic dependency and replacing its functionality with a streamlined solution, the overall footprint of the WebSocket-Node library is reduced, which is particularly beneficial for browser environments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully refactors the project to remove the es5-ext dependency, addressing a known bundling issue. The dependency is replaced by a lightweight, self-contained globalThis polyfill adapted from core-js, which is a great improvement for reducing the package size and complexity. The changes are clean and focused. My feedback includes a minor suggestion to improve code consistency in the new polyfill.

[SukkaW]

cc @theturtle32