Fix compatibility with lcobucci/jwt ^4.2 #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay on checking this. I had to work out why I'd used the assymetric signer for signing and the symmetric signer for decoding. It turns out it was to avoid a breaking change. Long term I want to modify the lib so users can pass their own config but for now, will need to stick with this. Thanks for spotting this |
|
No worries, thanks for tweaking and merging this. |
|
Hi @Sephster, is there a planned release with this fix? |
|
Likely in the next 48 hours 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Here is a forward compatibility layer for lcobucci ^4.2 and specifically this change lcobucci/jwt#833 which forbids creating
InMemorykeys with empty strings.Spotted in https://github.com/thephpleague/oauth2-server-bundle/runs/6077089570?check_suite_focus=true