-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use key as string without a temporary file #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ssigwart
commented
Dec 24, 2020
- Addresses Accept key content directly instead of require a key file #1007
- This allows you to use a private key from a string without writing to a temporary file. For security reasons, I'd rather not have the key written to disk on the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are removing the ability to use a password against the private key here. Is it possible to change this to accommodate this? Thanks for your submission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking @Sephster. I think my change addresses your comment.
@Sephster, is there anything I should do to get this merged? |
@Sephster, there are merge conflicts now. Should I rebase and resolve them? |
That would be appreciated cheers. I've been tidying up a personal project but hoping to get back to this within the week. Thanks very much |
Thanks, @Sephster. I rebased it and fixed the conflicts. |
@ssigwart would it be possible for you to resolve the conflict? I tried to do this myself but don't have write access to your branch. There is also a trailing comma on line 80 of the BearerToken file which is causing issues in PHP 7.2. Everything else looks good so happy to merge in once this is resolved. Thank you |
@Sephster, I fixed the trailing comma and rebased to fix the conflict. Thanks! |
Thanks @ssigwart - looks great. |