Skip to content

Fix label values query in stress; bump dependencies #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Sep 15, 2020

Signed-off-by: Ben Ye [email protected]

fix #29

This pr does:

  1. Add start and end param to labelValues gRPC query. Not sure this is good, maybe we can have some default value for it in proxy store?

  2. Update dependencies of Thanos and Prometheus

@yeya24 yeya24 force-pushed the fix-stress-labelvalues branch from 8fdab39 to e745314 Compare September 15, 2020 20:30
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Thanks for taking care of this.

@bwplotka bwplotka merged commit ebe2a13 into thanos-io:master Oct 20, 2020
@bwplotka
Copy link
Member

Amazing!

@yeya24 yeya24 deleted the fix-stress-labelvalues branch October 20, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

While running stress test I am getting err="the StoreAPI responded with zero metric names"
3 participants