Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cortex and remove usage of Prometheus fork. #4898

Merged

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Nov 24, 2021

This PR finishes update of Prometheus started in PR #4882. There we had to use custom fork of Prometheus with some deprecated packages, because Cortex was still using them. Now that Cortex has been updated by cortexproject/cortex#4560, we can finish Prometheus update in Thanos and remove use of Prometheus fork.

Query-frontend interfaces changed due to cortexproject/cortex#4486. Feature from that PR has not been integrated in this PR.

Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Copy link
Contributor Author

To make linter happy, I've also migrated import paths from github.com/go-kit/kit/log to github.com/go-kit/log.

Signed-off-by: Peter Štibraný <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@GiedriusS GiedriusS merged commit 19dcc79 into thanos-io:main Nov 25, 2021
@pstibrany pstibrany deleted the update-cortex-and-remove-prometheus-fork branch November 25, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants