Updated busybox sha; Added dependabot. #4202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daixiang0
reviewed
May 7, 2021
| schedule: | ||
| interval: "weekly" | ||
| labels: ["dependencies"] | ||
| - package_manager: "docker" |
There was a problem hiding this comment.
I do not see any rule about busybox SHA update rule, is it a magic?
There was a problem hiding this comment.
It actually works with digest, but not sure how it can detect ARM/AMD tbh, so that will not for now. Still I want to try this path (:
wiardvanrij
reviewed
May 7, 2021
| ifeq ($(arch), x86_64) | ||
| # amd64 | ||
| SHA="14d68ca3d69fceaa6224250c83d81d935c053fb13594c811038c461194599973" | ||
| BASE_DOCKER_SHA="de4af55df1f648a334e16437c550a2907e0aed4f0b0edf454b0b215a9349bdbb" |
There was a problem hiding this comment.
This sha is different than the default sha's for amd64 in the dockerfiles? Wouldn't these be the same or do we use some fallback?
There was a problem hiding this comment.
Since it is updated, notice the date in comment.
There was a problem hiding this comment.
We just always set it, maybe I can remove the one in dockefiles
There was a problem hiding this comment.
Isn't it easier that all 'tools' use the same version no? I made this mistake by not understanding/seeing it :p See this PR: #4171
|
Sweet to use dependabot :D |
|
Need to re-trigger CI |
Signed-off-by: Bartlomiej Plotka <[email protected]>
kakkoyun
approved these changes
May 7, 2021
2 tasks
bwplotka
added a commit
that referenced
this pull request
May 7, 2021
Signed-off-by: Bartlomiej Plotka <[email protected]>
2 tasks
onprem
pushed a commit
that referenced
this pull request
May 19, 2021
Signed-off-by: Bartlomiej Plotka <[email protected]>
kakkoyun
pushed a commit
that referenced
this pull request
May 20, 2021
* UI: Fix infinite redirection loop on / Signed-off-by: Prem Saraswat <[email protected]> * Updated busybox sha; Added dependabot. (#4202) Signed-off-by: Bartlomiej Plotka <[email protected]> * Fixed dependabot yml. (#4205) Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>
kakkoyun
pushed a commit
to kakkoyun/thanos
that referenced
this pull request
May 21, 2021
* UI: Fix infinite redirection loop on / Signed-off-by: Prem Saraswat <[email protected]> * Updated busybox sha; Added dependabot. (thanos-io#4202) Signed-off-by: Bartlomiej Plotka <[email protected]> * Fixed dependabot yml. (thanos-io#4205) Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>
onprem
added a commit
that referenced
this pull request
May 21, 2021
* UI: Fix infinite redirection loop on / (#4208) * UI: Fix infinite redirection loop on / Signed-off-by: Prem Saraswat <[email protected]> * Updated busybox sha; Added dependabot. (#4202) Signed-off-by: Bartlomiej Plotka <[email protected]> * Fixed dependabot yml. (#4205) Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> * Cut release v0.20.2 (#4262) Signed-off-by: Kemal Akkoyun <[email protected]> Co-authored-by: Prem Saraswat <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka [email protected]