Replace sync/atomic with uber-go/atomic #2935

jvrplmlmn · 2020-07-24T14:45:28Z

Replaces the usage of sync/atomic with uber-go/atomic across the whole codebase.

This makes all access in the atomic variables atomic everywhere.

Closes #2928

I added CHANGELOG entry for this change.
Change is not relevant to the end user.

Changes

Replaced the usage of sync/atomic with uber-go/atomic.

Verification

I have run the unit tests for the project.

Replaces the usage of sync/atomic with uber-go/atomic across the whole codebase. This makes all access in the atomic variables atomic everywhere. Related with: thanos-io#2928 Signed-off-by: Javier Palomo <[email protected]>

GiedriusS

Looks good! One idea: let's update go-lint in Makefile so that these sync/atomic functions would be forbidden in the future and we wouldn't have to get back to this? Also, CircleCI is stuck on this PR and https://circleci.com/gh/thanos-io/workflows/thanos/tree/pull%2F2935 shows 404. Care pushing another commit to force the CI pipeline to start? Thank you (:

bwplotka

Thank you!

As @GiedriusS say we have easy way to make sure native atomic is forbidden (:

CHANGELOG.md

It checks that we are not directly importing 'sync/atomic'. Signed-off-by: Javier Palomo <[email protected]>

Signed-off-by: Javier Palomo <[email protected]>

jvrplmlmn · 2020-07-29T12:03:43Z

@GiedriusS sure thing, addressed in 8f8cd31

I can't see whats going on with CircleCI so not sure where is stuck.

GiedriusS · 2020-07-29T14:35:48Z

@GiedriusS sure thing, addressed in 8f8cd31

I can't see whats going on with CircleCI so not sure where is stuck.

Why have you decided to implement it yourself instead of using faillint (https://github.com/fatih/faillint) that we have already in our Makefile? :P

Signed-off-by: Javier Palomo <[email protected]>

jvrplmlmn · 2020-07-29T14:53:03Z

@GiedriusS simply I was not aware of that tool, it has been addressed in 3eab5f5

bwplotka

Thanks! One nit only (:

bwplotka · 2020-07-29T15:09:06Z

Makefile

@@ -268,6 +268,7 @@ github.com/prometheus/client_golang/prometheus.{NewCounter,NewCounterVec,NewCoun
 NewHistorgram,NewHistogramVec,NewSummary,NewSummaryVec}=github.com/prometheus/client_golang/prometheus/promauto.{NewCounter,\
 NewCounterVec,NewCounterVec,NewGauge,NewGaugeVec,NewGaugeFunc,NewHistorgram,NewHistogramVec,NewSummary,NewSummaryVec}" ./...
 	@$(FAILLINT) -paths "fmt.{Print,Println,Sprint}" -ignore-tests ./...
+	@$(FAILLINT) -paths "sync/atomic" ./...


Let's add "sync/atomic=github.com/uber-go/atomic" to 2 lines above (with histogram) (: No need to create another line

Addressed in a422f52.

I have used go.uber.org/atomic as opposed to github.com/uber-go/atomic because the former is the preferred manner to import the package, see https://github.com/uber-go/atomic#legacy-import-path

Signed-off-by: Javier Palomo <[email protected]>

bwplotka

Thank you! 💪

jvrplmlmn · 2020-07-29T16:06:04Z

Not entirely sure whats going on with CircleCI, but somehow is not working for this branch 🤷‍♂️

Signed-off-by: Giedrius Statkevičius <[email protected]>

GiedriusS · 2020-07-29T19:32:26Z

Not entirely sure whats going on with CircleCI, but somehow is not working for this branch man_shrugging

I have added an empty commit to kick it off. That seems to be the easiest way to force it to re-run. BTW, don't confuse with brevity with hostility - it's perfectly fine that you've missed that we have a native tool for this already 🤗 I do and everyone does mistakes, especially if we've just started contributing to some project

GiedriusS

LGTM, Netlify CI jobs are still flaky and/or they don't like empty commits. I am going to use my super admin powers to merge this since this isn't touching the web site at all 😄

* Replace sync/atomic with uber-go/atomic Replaces the usage of sync/atomic with uber-go/atomic across the whole codebase. This makes all access in the atomic variables atomic everywhere. Related with: thanos-io#2928 Signed-off-by: Javier Palomo <[email protected]> * scripts: Verify that we are not using restricted packages It checks that we are not directly importing 'sync/atomic'. Signed-off-by: Javier Palomo <[email protected]> * Remove unnecesary addition to CHANGELOG Signed-off-by: Javier Palomo <[email protected]> * Use faillint to ensure that sync/atomic is not being used Signed-off-by: Javier Palomo <[email protected]> * Faillint: Add a replacement suggestion for 'sync/atomic' Signed-off-by: Javier Palomo <[email protected]> * Kick off CI Signed-off-by: Giedrius Statkevičius <[email protected]> Co-authored-by: Giedrius Statkevičius <[email protected]> Signed-off-by: soniasingla <[email protected]>

This reverts commit 20a82b9.

* Replace sync/atomic with uber-go/atomic Replaces the usage of sync/atomic with uber-go/atomic across the whole codebase. This makes all access in the atomic variables atomic everywhere. Related with: thanos-io#2928 Signed-off-by: Javier Palomo <[email protected]> * scripts: Verify that we are not using restricted packages It checks that we are not directly importing 'sync/atomic'. Signed-off-by: Javier Palomo <[email protected]> * Remove unnecesary addition to CHANGELOG Signed-off-by: Javier Palomo <[email protected]> * Use faillint to ensure that sync/atomic is not being used Signed-off-by: Javier Palomo <[email protected]> * Faillint: Add a replacement suggestion for 'sync/atomic' Signed-off-by: Javier Palomo <[email protected]> * Kick off CI Signed-off-by: Giedrius Statkevičius <[email protected]> Co-authored-by: Giedrius Statkevičius <[email protected]> Signed-off-by: soniasingla <[email protected]>

This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]>

Signed-off-by: soniasingla <[email protected]> Updated step-4 with nit improvements Signed-off-by: soniasingla <[email protected]> cached, loaded Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/intro.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> refactored states Signed-off-by: soniasingla <[email protected]> Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)" This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]> Revert "cleanup shipper NewWithCompacted function (thanos-io#2940)" This reverts commit 2a54885. Signed-off-by: soniasingla <[email protected]> running querier Signed-off-by: soniasingla <[email protected]> Adding updated thanos version Signed-off-by: soniasingla <[email protected]> tutorials/katacoda/thanos/2-lts/index.json ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~users querying data Signed-off-by: soniasingla <[email protected]>

Signed-off-by: soniasingla <[email protected]> Update sidecar container Signed-off-by: soniasingla <[email protected]> Update compactor container Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Update thanosbench container Signed-off-by: soniasingla <[email protected]> Add the newly generated image into sh file Signed-off-by: soniasingla <[email protected]> Updated image for all platforms(non-linux users) Signed-off-by: soniasingla <[email protected]> Update container for better picture Signed-off-by: soniasingla <[email protected]> Let's add more info Signed-off-by: soniasingla <[email protected]> Updating docker image and added thanosbench Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> Update: Content Signed-off-by: soniasingla <[email protected]> Mounting the data into host Signed-off-by: soniasingla <[email protected]> Prometheus container Signed-off-by: soniasingla <[email protected]> Update the deployment and metrics docker Signed-off-by: soniasingla <[email protected]> Disbale compaction and change minio with TSDB step Signed-off-by: soniasingla <[email protected]> Add step to stop sidecar Signed-off-by: soniasingla <[email protected]> added thanos bucket and updated store container Signed-off-by: soniasingla <[email protected]> Updates sidecar container Signed-off-by: soniasingla <[email protected]> IP address correctly added and minor changes Signed-off-by: soniasingla <[email protected]> Updated step-3 Signed-off-by: soniasingla <[email protected]> Updated step-3 with nit improvements Signed-off-by: soniasingla <[email protected]> Updated step-4 with nit improvements Signed-off-by: soniasingla <[email protected]> cached, loaded Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/intro.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> refactored states Signed-off-by: soniasingla <[email protected]> Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)" This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]> Revert "cleanup shipper NewWithCompacted function (thanos-io#2940)" This reverts commit 2a54885. Signed-off-by: soniasingla <[email protected]> running querier Signed-off-by: soniasingla <[email protected]> Adding updated thanos version Signed-off-by: soniasingla <[email protected]> tutorials/katacoda/thanos/2-lts/index.json ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~users querying data Signed-off-by: soniasingla <[email protected]>

Signed-off-by: soniasingla <[email protected]> No image error Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> CE Signed-off-by: soniasingla <[email protected]> Changing 2 servers to 1 server Signed-off-by: soniasingla <[email protected]> Update in step-2 Signed-off-by: soniasingla <[email protected]> Update Prometheus version Signed-off-by: soniasingla <[email protected]> update bash Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> configuration path Signed-off-by: soniasingla <[email protected]> configuration added Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update store conatiner Signed-off-by: soniasingla <[email protected]> added description, removed in progress Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation files Signed-off-by: soniasingla <[email protected]> Adding metrics path Signed-off-by: soniasingla <[email protected]> i did it Signed-off-by: soniasingla <[email protected]> Verification : Step-3 Signed-off-by: soniasingla <[email protected]> Remove double into Signed-off-by: soniasingla <[email protected]> grammarly fixes Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Configuration update, Added Thanos Querier, and TODO steps Signed-off-by: soniasingla <[email protected]> Fix comma error in step-4 Signed-off-by: soniasingla <[email protected]> Fix errors in step-4 Signed-off-by: soniasingla <[email protected]> nipticks Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> Update minio container Signed-off-by: soniasingla <[email protected]> Add minio verification Signed-off-by: soniasingla <[email protected]> Update sidecar container Signed-off-by: soniasingla <[email protected]> Update compactor container Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Update thanosbench container Signed-off-by: soniasingla <[email protected]> Add the newly generated image into sh file Signed-off-by: soniasingla <[email protected]> Updated image for all platforms(non-linux users) Signed-off-by: soniasingla <[email protected]> Update container for better picture Signed-off-by: soniasingla <[email protected]> Let's add more info Signed-off-by: soniasingla <[email protected]> Updating docker image and added thanosbench Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> Update: Content Signed-off-by: soniasingla <[email protected]> Mounting the data into host Signed-off-by: soniasingla <[email protected]> Prometheus container Signed-off-by: soniasingla <[email protected]> Update the deployment and metrics docker Signed-off-by: soniasingla <[email protected]> Disbale compaction and change minio with TSDB step Signed-off-by: soniasingla <[email protected]> Add step to stop sidecar Signed-off-by: soniasingla <[email protected]> added thanos bucket and updated store container Signed-off-by: soniasingla <[email protected]> Updates sidecar container Signed-off-by: soniasingla <[email protected]> IP address correctly added and minor changes Signed-off-by: soniasingla <[email protected]> Updated step-3 Signed-off-by: soniasingla <[email protected]> Updated step-3 with nit improvements Signed-off-by: soniasingla <[email protected]> Updated step-4 with nit improvements Signed-off-by: soniasingla <[email protected]> cached, loaded Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/intro.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> refactored states Signed-off-by: soniasingla <[email protected]> Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)" This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]> Revert "cleanup shipper NewWithCompacted function (thanos-io#2940)" This reverts commit 2a54885. Signed-off-by: soniasingla <[email protected]> running querier Signed-off-by: soniasingla <[email protected]> Adding updated thanos version Signed-off-by: soniasingla <[email protected]> tutorials/katacoda/thanos/2-lts/index.json ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~users querying data Signed-off-by: soniasingla <[email protected]>

Signed-off-by: soniasingla <[email protected]> Added Intro File Signed-off-by: soniasingla <[email protected]> Adding Initial Setup File Signed-off-by: soniasingla <[email protected]> Files : Initial Setup and Verification Signed-off-by: soniasingla <[email protected]> Initial prometheus servers Signed-off-by: soniasingla <[email protected]> Updating 3 prometheus to 2 prometheus Signed-off-by: soniasingla <[email protected]> Updating Step-2 and Verification Signed-off-by: soniasingla <[email protected]> bash file Signed-off-by: soniasingla <[email protected]> Update JSON file: Environment and files Signed-off-by: soniasingla <[email protected]> Details and verification Signed-off-by: soniasingla <[email protected]> Step3 Bash file Signed-off-by: soniasingla <[email protected]> script changes added Signed-off-by: soniasingla <[email protected]> Step 2: Verification updated Signed-off-by: soniasingla <[email protected]> Update in step 3 Signed-off-by: soniasingla <[email protected]> Nit improvements Signed-off-by: soniasingla <[email protected]> step 4 updated Signed-off-by: soniasingla <[email protected]> Updated Signed-off-by: soniasingla <[email protected]> Deployed Thanos Store Gateway Signed-off-by: soniasingla <[email protected]> Bash script as per step-3 Signed-off-by: soniasingla <[email protected]> No image error Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> CE Signed-off-by: soniasingla <[email protected]> Changing 2 servers to 1 server Signed-off-by: soniasingla <[email protected]> Update in step-2 Signed-off-by: soniasingla <[email protected]> Update Prometheus version Signed-off-by: soniasingla <[email protected]> update bash Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> configuration path Signed-off-by: soniasingla <[email protected]> configuration added Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update store conatiner Signed-off-by: soniasingla <[email protected]> added description, removed in progress Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation files Signed-off-by: soniasingla <[email protected]> Adding metrics path Signed-off-by: soniasingla <[email protected]> i did it Signed-off-by: soniasingla <[email protected]> Verification : Step-3 Signed-off-by: soniasingla <[email protected]> Remove double into Signed-off-by: soniasingla <[email protected]> grammarly fixes Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Configuration update, Added Thanos Querier, and TODO steps Signed-off-by: soniasingla <[email protected]> Fix comma error in step-4 Signed-off-by: soniasingla <[email protected]> Fix errors in step-4 Signed-off-by: soniasingla <[email protected]> nipticks Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> Update minio container Signed-off-by: soniasingla <[email protected]> Add minio verification Signed-off-by: soniasingla <[email protected]> Update sidecar container Signed-off-by: soniasingla <[email protected]> Update compactor container Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Update thanosbench container Signed-off-by: soniasingla <[email protected]> Add the newly generated image into sh file Signed-off-by: soniasingla <[email protected]> Updated image for all platforms(non-linux users) Signed-off-by: soniasingla <[email protected]> Update container for better picture Signed-off-by: soniasingla <[email protected]> Let's add more info Signed-off-by: soniasingla <[email protected]> Updating docker image and added thanosbench Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> Update: Content Signed-off-by: soniasingla <[email protected]> Mounting the data into host Signed-off-by: soniasingla <[email protected]> Prometheus container Signed-off-by: soniasingla <[email protected]> Update the deployment and metrics docker Signed-off-by: soniasingla <[email protected]> Disbale compaction and change minio with TSDB step Signed-off-by: soniasingla <[email protected]> Add step to stop sidecar Signed-off-by: soniasingla <[email protected]> added thanos bucket and updated store container Signed-off-by: soniasingla <[email protected]> Updates sidecar container Signed-off-by: soniasingla <[email protected]> IP address correctly added and minor changes Signed-off-by: soniasingla <[email protected]> Updated step-3 Signed-off-by: soniasingla <[email protected]> Updated step-3 with nit improvements Signed-off-by: soniasingla <[email protected]> Updated step-4 with nit improvements Signed-off-by: soniasingla <[email protected]> cached, loaded Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/intro.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> refactored states Signed-off-by: soniasingla <[email protected]> Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)" This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]> Revert "cleanup shipper NewWithCompacted function (thanos-io#2940)" This reverts commit 2a54885. Signed-off-by: soniasingla <[email protected]> running querier Signed-off-by: soniasingla <[email protected]> Adding updated thanos version Signed-off-by: soniasingla <[email protected]> tutorials/katacoda/thanos/2-lts/index.json ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~users querying data Signed-off-by: soniasingla <[email protected]>

Signed-off-by: soniasingla <[email protected]> Added Intro File Signed-off-by: soniasingla <[email protected]> Adding Initial Setup File Signed-off-by: soniasingla <[email protected]> Files : Initial Setup and Verification Signed-off-by: soniasingla <[email protected]> Initial prometheus servers Signed-off-by: soniasingla <[email protected]> Updating 3 prometheus to 2 prometheus Signed-off-by: soniasingla <[email protected]> Updating Step-2 and Verification Signed-off-by: soniasingla <[email protected]> bash file Signed-off-by: soniasingla <[email protected]> Update JSON file: Environment and files Signed-off-by: soniasingla <[email protected]> Details and verification Signed-off-by: soniasingla <[email protected]> Step3 Bash file Signed-off-by: soniasingla <[email protected]> script changes added Signed-off-by: soniasingla <[email protected]> Step 2: Verification updated Signed-off-by: soniasingla <[email protected]> Update in step 3 Signed-off-by: soniasingla <[email protected]> Nit improvements Signed-off-by: soniasingla <[email protected]> step 4 updated Signed-off-by: soniasingla <[email protected]> Updated Signed-off-by: soniasingla <[email protected]> Deployed Thanos Store Gateway Signed-off-by: soniasingla <[email protected]> Bash script as per step-3 Signed-off-by: soniasingla <[email protected]> No image error Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> CE Signed-off-by: soniasingla <[email protected]> Changing 2 servers to 1 server Signed-off-by: soniasingla <[email protected]> Update in step-2 Signed-off-by: soniasingla <[email protected]> Update Prometheus version Signed-off-by: soniasingla <[email protected]> update bash Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> configuration path Signed-off-by: soniasingla <[email protected]> configuration added Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update store conatiner Signed-off-by: soniasingla <[email protected]> added description, removed in progress Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation files Signed-off-by: soniasingla <[email protected]> Adding metrics path Signed-off-by: soniasingla <[email protected]> i did it Signed-off-by: soniasingla <[email protected]> Verification : Step-3 Signed-off-by: soniasingla <[email protected]> Remove double into Signed-off-by: soniasingla <[email protected]> grammarly fixes Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Configuration update, Added Thanos Querier, and TODO steps Signed-off-by: soniasingla <[email protected]> Fix comma error in step-4 Signed-off-by: soniasingla <[email protected]> Fix errors in step-4 Signed-off-by: soniasingla <[email protected]> nipticks Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> Update minio container Signed-off-by: soniasingla <[email protected]> Add minio verification Signed-off-by: soniasingla <[email protected]> Update sidecar container Signed-off-by: soniasingla <[email protected]> Update compactor container Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Update thanosbench container Signed-off-by: soniasingla <[email protected]> Add the newly generated image into sh file Signed-off-by: soniasingla <[email protected]> Updated image for all platforms(non-linux users) Signed-off-by: soniasingla <[email protected]> Update container for better picture Signed-off-by: soniasingla <[email protected]> Let's add more info Signed-off-by: soniasingla <[email protected]> Updating docker image and added thanosbench Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> Update: Content Signed-off-by: soniasingla <[email protected]> Mounting the data into host Signed-off-by: soniasingla <[email protected]> Prometheus container Signed-off-by: soniasingla <[email protected]> Update the deployment and metrics docker Signed-off-by: soniasingla <[email protected]> Disbale compaction and change minio with TSDB step Signed-off-by: soniasingla <[email protected]> Add step to stop sidecar Signed-off-by: soniasingla <[email protected]> added thanos bucket and updated store container Signed-off-by: soniasingla <[email protected]> Updates sidecar container Signed-off-by: soniasingla <[email protected]> IP address correctly added and minor changes Signed-off-by: soniasingla <[email protected]> Updated step-3 Signed-off-by: soniasingla <[email protected]> Updated step-3 with nit improvements Signed-off-by: soniasingla <[email protected]> Updated step-4 with nit improvements Signed-off-by: soniasingla <[email protected]> cached, loaded Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/intro.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> refactored states Signed-off-by: soniasingla <[email protected]> Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)" This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]> Revert "cleanup shipper NewWithCompacted function (thanos-io#2940)" This reverts commit 2a54885. Signed-off-by: soniasingla <[email protected]> running querier Signed-off-by: soniasingla <[email protected]> Adding updated thanos version Signed-off-by: soniasingla <[email protected]> tutorials/katacoda/thanos/2-lts/index.json ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~users querying data Signed-off-by: soniasingla <[email protected]> Cleaning up Signed-off-by: soniasingla <[email protected]>

Signed-off-by: soniasingla <[email protected]> Added Intro File Signed-off-by: soniasingla <[email protected]> Adding Initial Setup File Signed-off-by: soniasingla <[email protected]> Files : Initial Setup and Verification Signed-off-by: soniasingla <[email protected]> Initial prometheus servers Signed-off-by: soniasingla <[email protected]> Updating 3 prometheus to 2 prometheus Signed-off-by: soniasingla <[email protected]> Updating Step-2 and Verification Signed-off-by: soniasingla <[email protected]> bash file Signed-off-by: soniasingla <[email protected]> Update JSON file: Environment and files Signed-off-by: soniasingla <[email protected]> Details and verification Signed-off-by: soniasingla <[email protected]> Step3 Bash file Signed-off-by: soniasingla <[email protected]> script changes added Signed-off-by: soniasingla <[email protected]> Step 2: Verification updated Signed-off-by: soniasingla <[email protected]> Update in step 3 Signed-off-by: soniasingla <[email protected]> Nit improvements Signed-off-by: soniasingla <[email protected]> step 4 updated Signed-off-by: soniasingla <[email protected]> Updated Signed-off-by: soniasingla <[email protected]> Deployed Thanos Store Gateway Signed-off-by: soniasingla <[email protected]> Bash script as per step-3 Signed-off-by: soniasingla <[email protected]> No image error Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> CE Signed-off-by: soniasingla <[email protected]> Changing 2 servers to 1 server Signed-off-by: soniasingla <[email protected]> Update in step-2 Signed-off-by: soniasingla <[email protected]> Update Prometheus version Signed-off-by: soniasingla <[email protected]> update bash Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> configuration path Signed-off-by: soniasingla <[email protected]> configuration added Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update store conatiner Signed-off-by: soniasingla <[email protected]> added description, removed in progress Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation files Signed-off-by: soniasingla <[email protected]> Adding metrics path Signed-off-by: soniasingla <[email protected]> i did it Signed-off-by: soniasingla <[email protected]> Verification : Step-3 Signed-off-by: soniasingla <[email protected]> Remove double into Signed-off-by: soniasingla <[email protected]> grammarly fixes Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Configuration update, Added Thanos Querier, and TODO steps Signed-off-by: soniasingla <[email protected]> Fix comma error in step-4 Signed-off-by: soniasingla <[email protected]> Fix errors in step-4 Signed-off-by: soniasingla <[email protected]> nipticks Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> Update minio container Signed-off-by: soniasingla <[email protected]> Add minio verification Signed-off-by: soniasingla <[email protected]> Update sidecar container Signed-off-by: soniasingla <[email protected]> Update compactor container Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Update thanosbench container Signed-off-by: soniasingla <[email protected]> Add the newly generated image into sh file Signed-off-by: soniasingla <[email protected]> Updated image for all platforms(non-linux users) Signed-off-by: soniasingla <[email protected]> Update container for better picture Signed-off-by: soniasingla <[email protected]> Let's add more info Signed-off-by: soniasingla <[email protected]> Updating docker image and added thanosbench Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> Update: Content Signed-off-by: soniasingla <[email protected]> Mounting the data into host Signed-off-by: soniasingla <[email protected]> Prometheus container Signed-off-by: soniasingla <[email protected]> Update the deployment and metrics docker Signed-off-by: soniasingla <[email protected]> Disbale compaction and change minio with TSDB step Signed-off-by: soniasingla <[email protected]> Add step to stop sidecar Signed-off-by: soniasingla <[email protected]> added thanos bucket and updated store container Signed-off-by: soniasingla <[email protected]> Updates sidecar container Signed-off-by: soniasingla <[email protected]> IP address correctly added and minor changes Signed-off-by: soniasingla <[email protected]> Updated step-3 Signed-off-by: soniasingla <[email protected]> Updated step-3 with nit improvements Signed-off-by: soniasingla <[email protected]> Updated step-4 with nit improvements Signed-off-by: soniasingla <[email protected]> cached, loaded Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/intro.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> refactored states Signed-off-by: soniasingla <[email protected]> Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)" This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]> Revert "cleanup shipper NewWithCompacted function (thanos-io#2940)" This reverts commit 2a54885. Signed-off-by: soniasingla <[email protected]> running querier Signed-off-by: soniasingla <[email protected]> Adding updated thanos version Signed-off-by: soniasingla <[email protected]> tutorials/katacoda/thanos/2-lts/index.json ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~users querying data Signed-off-by: soniasingla <[email protected]> Cleaning up Signed-off-by: soniasingla <[email protected]> Removing new line from compactor Signed-off-by: soniasingla <[email protected]> Formatting all the files Signed-off-by: soniasingla <[email protected]> Linting & Formatting Signed-off-by: soniasingla <[email protected]>

…rometheus (#2840) * Tutorial : Downsampling and Unlimited Metric Retention for Prometheus. Signed-off-by: soniasingla <[email protected]> Added Intro File Signed-off-by: soniasingla <[email protected]> Adding Initial Setup File Signed-off-by: soniasingla <[email protected]> Files : Initial Setup and Verification Signed-off-by: soniasingla <[email protected]> Initial prometheus servers Signed-off-by: soniasingla <[email protected]> Updating 3 prometheus to 2 prometheus Signed-off-by: soniasingla <[email protected]> Updating Step-2 and Verification Signed-off-by: soniasingla <[email protected]> bash file Signed-off-by: soniasingla <[email protected]> Update JSON file: Environment and files Signed-off-by: soniasingla <[email protected]> Details and verification Signed-off-by: soniasingla <[email protected]> Step3 Bash file Signed-off-by: soniasingla <[email protected]> script changes added Signed-off-by: soniasingla <[email protected]> Step 2: Verification updated Signed-off-by: soniasingla <[email protected]> Update in step 3 Signed-off-by: soniasingla <[email protected]> Nit improvements Signed-off-by: soniasingla <[email protected]> step 4 updated Signed-off-by: soniasingla <[email protected]> Updated Signed-off-by: soniasingla <[email protected]> Deployed Thanos Store Gateway Signed-off-by: soniasingla <[email protected]> Bash script as per step-3 Signed-off-by: soniasingla <[email protected]> No image error Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> CE Signed-off-by: soniasingla <[email protected]> Changing 2 servers to 1 server Signed-off-by: soniasingla <[email protected]> Update in step-2 Signed-off-by: soniasingla <[email protected]> Update Prometheus version Signed-off-by: soniasingla <[email protected]> update bash Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> configuration path Signed-off-by: soniasingla <[email protected]> configuration added Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update store conatiner Signed-off-by: soniasingla <[email protected]> added description, removed in progress Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation files Signed-off-by: soniasingla <[email protected]> Adding metrics path Signed-off-by: soniasingla <[email protected]> i did it Signed-off-by: soniasingla <[email protected]> Verification : Step-3 Signed-off-by: soniasingla <[email protected]> Remove double into Signed-off-by: soniasingla <[email protected]> grammarly fixes Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Configuration update, Added Thanos Querier, and TODO steps Signed-off-by: soniasingla <[email protected]> Fix comma error in step-4 Signed-off-by: soniasingla <[email protected]> Fix errors in step-4 Signed-off-by: soniasingla <[email protected]> nipticks Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> Update minio container Signed-off-by: soniasingla <[email protected]> Add minio verification Signed-off-by: soniasingla <[email protected]> Update sidecar container Signed-off-by: soniasingla <[email protected]> Update compactor container Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Update thanosbench container Signed-off-by: soniasingla <[email protected]> Add the newly generated image into sh file Signed-off-by: soniasingla <[email protected]> Updated image for all platforms(non-linux users) Signed-off-by: soniasingla <[email protected]> Update container for better picture Signed-off-by: soniasingla <[email protected]> Let's add more info Signed-off-by: soniasingla <[email protected]> Updating docker image and added thanosbench Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> Update: Content Signed-off-by: soniasingla <[email protected]> Mounting the data into host Signed-off-by: soniasingla <[email protected]> Prometheus container Signed-off-by: soniasingla <[email protected]> Update the deployment and metrics docker Signed-off-by: soniasingla <[email protected]> Disbale compaction and change minio with TSDB step Signed-off-by: soniasingla <[email protected]> Add step to stop sidecar Signed-off-by: soniasingla <[email protected]> added thanos bucket and updated store container Signed-off-by: soniasingla <[email protected]> Updates sidecar container Signed-off-by: soniasingla <[email protected]> IP address correctly added and minor changes Signed-off-by: soniasingla <[email protected]> Updated step-3 Signed-off-by: soniasingla <[email protected]> Updated step-3 with nit improvements Signed-off-by: soniasingla <[email protected]> Updated step-4 with nit improvements Signed-off-by: soniasingla <[email protected]> cached, loaded Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/intro.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> refactored states Signed-off-by: soniasingla <[email protected]> Revert "Replace sync/atomic with uber-go/atomic (#2935)" This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]> Revert "cleanup shipper NewWithCompacted function (#2940)" This reverts commit 2a54885. Signed-off-by: soniasingla <[email protected]> running querier Signed-off-by: soniasingla <[email protected]> Adding updated thanos version Signed-off-by: soniasingla <[email protected]> tutorials/katacoda/thanos/2-lts/index.json ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~users querying data Signed-off-by: soniasingla <[email protected]> Cleaning up Signed-off-by: soniasingla <[email protected]> Removing new line from compactor Signed-off-by: soniasingla <[email protected]> Formatting all the files Signed-off-by: soniasingla <[email protected]> Linting & Formatting Signed-off-by: soniasingla <[email protected]> * fixes and updates Signed-off-by: soniasingla <[email protected]> * Tiny modifications and improvements to LTS tutorial. Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Tiny modifications and improvements to LTS tutorial. Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> * Tiny modifications and improvements to LTS tutorial. Signed-off-by: Bartlomiej Plotka <[email protected]> * Nit Improvements Signed-off-by: soniasingla <[email protected]> * Modifications and Improvements Signed-off-by: soniasingla <[email protected]> * Updates added Signed-off-by: soniasingla <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>

…rometheus (thanos-io#2840) * Tutorial : Downsampling and Unlimited Metric Retention for Prometheus. Signed-off-by: soniasingla <[email protected]> Added Intro File Signed-off-by: soniasingla <[email protected]> Adding Initial Setup File Signed-off-by: soniasingla <[email protected]> Files : Initial Setup and Verification Signed-off-by: soniasingla <[email protected]> Initial prometheus servers Signed-off-by: soniasingla <[email protected]> Updating 3 prometheus to 2 prometheus Signed-off-by: soniasingla <[email protected]> Updating Step-2 and Verification Signed-off-by: soniasingla <[email protected]> bash file Signed-off-by: soniasingla <[email protected]> Update JSON file: Environment and files Signed-off-by: soniasingla <[email protected]> Details and verification Signed-off-by: soniasingla <[email protected]> Step3 Bash file Signed-off-by: soniasingla <[email protected]> script changes added Signed-off-by: soniasingla <[email protected]> Step 2: Verification updated Signed-off-by: soniasingla <[email protected]> Update in step 3 Signed-off-by: soniasingla <[email protected]> Nit improvements Signed-off-by: soniasingla <[email protected]> step 4 updated Signed-off-by: soniasingla <[email protected]> Updated Signed-off-by: soniasingla <[email protected]> Deployed Thanos Store Gateway Signed-off-by: soniasingla <[email protected]> Bash script as per step-3 Signed-off-by: soniasingla <[email protected]> No image error Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> step 4, wohps Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> thanos quay Signed-off-by: soniasingla <[email protected]> CE Signed-off-by: soniasingla <[email protected]> Changing 2 servers to 1 server Signed-off-by: soniasingla <[email protected]> Update in step-2 Signed-off-by: soniasingla <[email protected]> Update Prometheus version Signed-off-by: soniasingla <[email protected]> update bash Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> add minio Signed-off-by: soniasingla <[email protected]> configuration path Signed-off-by: soniasingla <[email protected]> configuration added Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update store conatiner Signed-off-by: soniasingla <[email protected]> added description, removed in progress Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation file Signed-off-by: soniasingla <[email protected]> Add automation files Signed-off-by: soniasingla <[email protected]> Adding metrics path Signed-off-by: soniasingla <[email protected]> i did it Signed-off-by: soniasingla <[email protected]> Verification : Step-3 Signed-off-by: soniasingla <[email protected]> Remove double into Signed-off-by: soniasingla <[email protected]> grammarly fixes Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Thanos Compactor Signed-off-by: soniasingla <[email protected]> Configuration update, Added Thanos Querier, and TODO steps Signed-off-by: soniasingla <[email protected]> Fix comma error in step-4 Signed-off-by: soniasingla <[email protected]> Fix errors in step-4 Signed-off-by: soniasingla <[email protected]> nipticks Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> update docker container Signed-off-by: soniasingla <[email protected]> Update minio container Signed-off-by: soniasingla <[email protected]> Add minio verification Signed-off-by: soniasingla <[email protected]> Update sidecar container Signed-off-by: soniasingla <[email protected]> Update compactor container Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Add thanosbench to generate blocks Signed-off-by: soniasingla <[email protected]> Update thanosbench container Signed-off-by: soniasingla <[email protected]> Add the newly generated image into sh file Signed-off-by: soniasingla <[email protected]> Updated image for all platforms(non-linux users) Signed-off-by: soniasingla <[email protected]> Update container for better picture Signed-off-by: soniasingla <[email protected]> Let's add more info Signed-off-by: soniasingla <[email protected]> Updating docker image and added thanosbench Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> some nit fixes Signed-off-by: soniasingla <[email protected]> Update: Content Signed-off-by: soniasingla <[email protected]> Mounting the data into host Signed-off-by: soniasingla <[email protected]> Prometheus container Signed-off-by: soniasingla <[email protected]> Update the deployment and metrics docker Signed-off-by: soniasingla <[email protected]> Disbale compaction and change minio with TSDB step Signed-off-by: soniasingla <[email protected]> Add step to stop sidecar Signed-off-by: soniasingla <[email protected]> added thanos bucket and updated store container Signed-off-by: soniasingla <[email protected]> Updates sidecar container Signed-off-by: soniasingla <[email protected]> IP address correctly added and minor changes Signed-off-by: soniasingla <[email protected]> Updated step-3 Signed-off-by: soniasingla <[email protected]> Updated step-3 with nit improvements Signed-off-by: soniasingla <[email protected]> Updated step-4 with nit improvements Signed-off-by: soniasingla <[email protected]> cached, loaded Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> updated sh file Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> nit improvements Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/intro.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Update tutorials/katacoda/thanos/2-lts/step1.md Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> refactored states Signed-off-by: soniasingla <[email protected]> Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)" This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]> Revert "cleanup shipper NewWithCompacted function (thanos-io#2940)" This reverts commit 2a54885. Signed-off-by: soniasingla <[email protected]> running querier Signed-off-by: soniasingla <[email protected]> Adding updated thanos version Signed-off-by: soniasingla <[email protected]> tutorials/katacoda/thanos/2-lts/index.json ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~users querying data Signed-off-by: soniasingla <[email protected]> Cleaning up Signed-off-by: soniasingla <[email protected]> Removing new line from compactor Signed-off-by: soniasingla <[email protected]> Formatting all the files Signed-off-by: soniasingla <[email protected]> Linting & Formatting Signed-off-by: soniasingla <[email protected]> * fixes and updates Signed-off-by: soniasingla <[email protected]> * Tiny modifications and improvements to LTS tutorial. Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> Tiny modifications and improvements to LTS tutorial. Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: soniasingla <[email protected]> * Tiny modifications and improvements to LTS tutorial. Signed-off-by: Bartlomiej Plotka <[email protected]> * Nit Improvements Signed-off-by: soniasingla <[email protected]> * Modifications and Improvements Signed-off-by: soniasingla <[email protected]> * Updates added Signed-off-by: soniasingla <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Oghenebrume50 <[email protected]>

jvrplmlmn force-pushed the use-ubergo-atomic branch from 398ca2b to 5d3ce5c Compare July 24, 2020 14:48

Replace sync/atomic with uber-go/atomic

809a8d6

Replaces the usage of sync/atomic with uber-go/atomic across the whole codebase. This makes all access in the atomic variables atomic everywhere. Related with: thanos-io#2928 Signed-off-by: Javier Palomo <[email protected]>

jvrplmlmn force-pushed the use-ubergo-atomic branch from 5d3ce5c to 809a8d6 Compare July 24, 2020 14:50

GiedriusS approved these changes Jul 24, 2020

View reviewed changes

bwplotka approved these changes Jul 27, 2020

View reviewed changes

bwplotka reviewed Jul 27, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

jvrplmlmn added 2 commits July 29, 2020 13:52

scripts: Verify that we are not using restricted packages

8f8cd31

It checks that we are not directly importing 'sync/atomic'. Signed-off-by: Javier Palomo <[email protected]>

Remove unnecesary addition to CHANGELOG

6dd75ce

Signed-off-by: Javier Palomo <[email protected]>

Use faillint to ensure that sync/atomic is not being used

3eab5f5

Signed-off-by: Javier Palomo <[email protected]>

bwplotka approved these changes Jul 29, 2020

View reviewed changes

Faillint: Add a replacement suggestion for 'sync/atomic'

a422f52

Signed-off-by: Javier Palomo <[email protected]>

bwplotka approved these changes Jul 29, 2020

View reviewed changes

Kick off CI

0b183a7

Signed-off-by: Giedrius Statkevičius <[email protected]>

GiedriusS approved these changes Jul 29, 2020

View reviewed changes

GiedriusS merged commit 6b4bfa8 into thanos-io:master Jul 29, 2020

jvrplmlmn deleted the use-ubergo-atomic branch July 30, 2020 12:45

soniasingla added a commit to soniasingla/thanos that referenced this pull request Sep 26, 2020

Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)"

ba1b24a

This reverts commit 20a82b9.

soniasingla added a commit to soniasingla/thanos that referenced this pull request Sep 26, 2020

Revert "Replace sync/atomic with uber-go/atomic (thanos-io#2935)"

151d98f

This reverts commit 20a82b9. Signed-off-by: soniasingla <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace sync/atomic with uber-go/atomic #2935

Replace sync/atomic with uber-go/atomic #2935

jvrplmlmn commented Jul 24, 2020 •

edited by bwplotka

Loading

GiedriusS left a comment •

edited

Loading

bwplotka left a comment

jvrplmlmn commented Jul 29, 2020

GiedriusS commented Jul 29, 2020

jvrplmlmn commented Jul 29, 2020

bwplotka left a comment

bwplotka Jul 29, 2020

jvrplmlmn Jul 29, 2020

bwplotka left a comment

jvrplmlmn commented Jul 29, 2020

GiedriusS commented Jul 29, 2020

GiedriusS left a comment

Replace sync/atomic with uber-go/atomic #2935

Replace sync/atomic with uber-go/atomic #2935

Conversation

jvrplmlmn commented Jul 24, 2020 • edited by bwplotka Loading

Changes

Verification

GiedriusS left a comment • edited Loading

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

jvrplmlmn commented Jul 29, 2020

GiedriusS commented Jul 29, 2020

jvrplmlmn commented Jul 29, 2020

bwplotka left a comment

Choose a reason for hiding this comment

bwplotka Jul 29, 2020

Choose a reason for hiding this comment

jvrplmlmn Jul 29, 2020

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

jvrplmlmn commented Jul 29, 2020

GiedriusS commented Jul 29, 2020

GiedriusS left a comment

Choose a reason for hiding this comment

jvrplmlmn commented Jul 24, 2020 •

edited by bwplotka

Loading

GiedriusS left a comment •

edited

Loading