Hud screens now set hud owner in Initialize. #76772

JohnFulpWillard · 2023-07-12T03:07:46Z

About The Pull Request

Adds an arg in huds' screens to add the hud owner in the Initialize, instead of manually setting it every time we need to.
This is already done in New() for lobby screens, which I left intact as lobby screens are used for new players, and are given out before atoms are Initialized. Everything else, however, uses Initialize, so it does not mess with any other args in their own Initializes (like the Escape menu).
This also allows us to set the screens' HUDs as a private var, to ensure this won't be messed with in the future.
Lastly I replaced instances of client with cannon_client to be consistent with a lot of other parts of hud code.

Why It's Good For The Game

Huds are easy to break when they do not have a hud owner, and for something as important as that I believe it should be something you opt-out of when you don't want it, rather than something you opt-into by manually setting hud owner every time.
This cuts down on a lot of copy paste in hud code for humans, aliens, etc.

Changelog

🆑
refactor: Huds now have their hud owner set in Initialize
/:cl:

…6826) Original PR: tgstation/tgstation#76772 ----- ## About The Pull Request Adds an arg in huds' screens to add the hud owner in the Initialize, instead of manually setting it every time we need to. This is already done in ``New()`` for lobby screens, which I left intact as lobby screens are used for new players, and are given out before atoms are Initialized. Everything else, however, uses Initialize, so it does not mess with any other args in their own Initializes (like the Escape menu). This also allows us to set the screens' HUDs as a private var, to ensure this won't be messed with in the future. Lastly I replaced instances of ``client`` with ``cannon_client`` to be consistent with a lot of other parts of hud code. ## Why It's Good For The Game Huds are easy to break when they do not have a hud owner, and for something as important as that I believe it should be something you opt-out of when you don't want it, rather than something you opt-into by manually setting hud owner every time. This cuts down on a lot of copy paste in hud code for humans, aliens, etc. ## Changelog :cl: refactor: Huds now have their hud owner set in Initialize /:cl: --------- Co-authored-by: John Willard <[email protected]> Co-authored-by: Jolly-66 <[email protected]>

JOHNNNNNNNNNNNNNNNNNNNNNNNN Parallax layers are independent of the hud they're spawned from, tied instead to the client. #76772 caused them to hang a bunch of improper hard references to huds, so let's just make our own edge case here Hopefully this'll clear up #78015 and the logs it produces, make em more helpful

## About The Pull Request This PR ports the following PRs from tgstation: * tgstation/tgstation#76772 * tgstation/tgstation#88307 - Caused by 76772 * tgstation/tgstation#78066 - Caused by 76772 * tgstation/tgstation#83987 * tgstation/tgstation#76443 (Partial - just the code to support the other PRs) These changes are intended to fix various issues regarding HUDs. NOTE: While testing, I encountered certain HUD-related issues. The following is a list of issues I know NOT to be the result of this PR: * The Character setup screen would show your characters as super-tiny. (This is a bug caused by 516; reverting to 515 fixes the issue.) * The asterisk next to runechat emotes, as well as the mouse icons shown below the name of certain hovered objects, being much bigger. (This is a bug caused by 516; reverting to 515 fixes the issue.) * Taking possession of a `/mob/living/basic/possession_holder` will give you a black screen. (This is a bug caused by 516; reverting to 515 fixes the issue.) ## Why It's Good For The Game Bugfixes and better code. ## Changelog :cl:MichiRecRoom refactor: The code behind many HUD systems has been refactored slightly. Due to the massive amount of HUD types we have, I only tested monkestation-specific HUDs - so please let me know if you see any broken HUDs! refactor: (JohnFulpWillard) Huds now have their hud owner set in Initialize /:cl: --------- Co-authored-by: John Willard <[email protected]> Co-authored-by: SmArtKar <[email protected]> Co-authored-by: LemonInTheDark <[email protected]> Co-authored-by: Ben10Omintrix <[email protected]>

## About The Pull Request this is just some fixes split off from #6967 This fixes lobby screen fadeout not properly working (client needs to be the third argument, not second, due to #5830, as it ported tgstation/tgstation#76772), and also properly runs a storyteller process at roundstart. This did _nothing_: ```dm SSgamemode.current_storyteller.process(STORYTELLER_WAIT_TIME * 0.1) // we want this asap SSgamemode.current_storyteller.round_started = TRUE ``` because it set `round_started` to true _after_ process... so the process would just immediately exit: ```dm /datum/storyteller/process(seconds_per_tick) if(!round_started || disable_distribution) // we are differing roundstarted ones until base roundstart so we can get cooler stuff return ``` In addition, I've moved the storyteller process code to a new proc, `/datum/storyteller/proc/tick(seconds_per_tick)` This is _solely_ because `process()` sets waitfor = FALSE: ```dm /datum/proc/process(seconds_per_tick) set waitfor = FALSE ``` and thus any sleep would result in roundstart continuing before the storyteller setup finishes. I also made the lobby screen fadeout _after_ storyteller setup finished (+ 1 extra second), to hopefully reduce or eliminate the "someone sees their coworker who got chosen for nukie just disappear into thin air" thing. ## Why It's Good For The Game Fixes bugs, and hopefully reduces jank relating to roundstart antags being slightly delayed. ## Changelog :cl: fix: The lobby screen now properly fades out during roundstart/latejoin/ fix: Roundstart setup now properly immediately triggers the storyteller to process. /:cl:

## About The Pull Request ports a fix from Monkestation/Monkestation2.0#6991 #76772 accidentally broke most instances of using `/atom/movable/screen/splash`, bc now the client needs to be third instead of second argument to `new /atom/movable/screen/splash`... yeah. <details> <summary><h3>pre-fix video clip</h3></summary> https://github.com/user-attachments/assets/87015373-de72-4753-bf6e-55c3d9ffa207 </details> <details> <summary><h3>post-fix video clip</h3></summary> https://github.com/user-attachments/assets/3dc80c68-f4a5-44a7-95fe-d590affc273d </details> ## Why It's Good For The Game bugfix good ## Changelog :cl: fix: The lobby art properly fades out during roundstart, latejoin, and server restart again. /:cl:

## About The Pull Request ports a fix from Monkestation/Monkestation2.0#6991 tgstation/tgstation#76772 accidentally broke most instances of using `/atom/movable/screen/splash`, bc now the client needs to be third instead of second argument to `new /atom/movable/screen/splash`... yeah. <details> <summary><h3>pre-fix video clip</h3></summary> https://github.com/user-attachments/assets/87015373-de72-4753-bf6e-55c3d9ffa207 </details> <details> <summary><h3>post-fix video clip</h3></summary> https://github.com/user-attachments/assets/3dc80c68-f4a5-44a7-95fe-d590affc273d </details> ## Why It's Good For The Game bugfix good ## Changelog :cl: fix: The lobby art properly fades out during roundstart, latejoin, and server restart again. /:cl:

Ensure screens have a hud unless explicitly dont

93a9bdd

JohnFulpWillard requested review from ninjanomnom, LemonInTheDark and Fikou as code owners July 12, 2023 03:07

tgstation-server added the Refactor Makes the code harder to read label Jul 12, 2023

github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jul 13, 2023

Merge branch 'master' into hud-business

2b37006

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jul 13, 2023

JohnFulpWillard added 2 commits July 12, 2023 23:29

Makes HUDs a private var

2d9f17b

Update changeling.dm

83fc2fc

Time-Green merged commit 06ca7a4 into tgstation:master Jul 16, 2023

SkyratBot mentioned this pull request Jul 16, 2023

[MIRROR] Hud screens now set hud owner in Initialize. [MDB IGNORE] Skyrat-SS13/Skyrat-tg#22501

Merged

comfyorange added a commit that referenced this pull request Jul 16, 2023

Automatic changelog for PR #76772 [ci skip]

11f9bbc

TaleStationBot mentioned this pull request Jul 16, 2023

[MIRROR] [MDB IGNORE] Hud screens now set hud owner in Initialize. TaleStation/TaleStation#6826

Merged

github-actions bot added a commit that referenced this pull request Jul 16, 2023

Updating GBP balances for #76772

9f8aea5

Time-Green mentioned this pull request Jul 16, 2023

Temporarily reverts 76772 "Hud screens now set hud owner in Initialize." #76893

Closed

LemonInTheDark mentioned this pull request Sep 1, 2023

Resolves parallax harddels #78066

Merged

JohnFulpWillard deleted the hud-business branch November 27, 2023 06:31

Sealed101 mentioned this pull request Oct 22, 2024

Changeling UI runtimes #66668

Closed

LikeLakers2 added this to [PORT] HUD stuff Mar 6, 2025

LikeLakers2 moved this to Todo in [PORT] HUD stuff Mar 6, 2025

LikeLakers2 moved this from Todo to In Progress in [PORT] HUD stuff Mar 6, 2025

LikeLakers2 mentioned this pull request Mar 6, 2025

[PORTS] HUD Screen stuff Monkestation/Monkestation2.0#5830

Merged

LikeLakers2 moved this from In Progress to Submitted in [PORT] HUD stuff Mar 6, 2025

LikeLakers2 mentioned this pull request Mar 6, 2025

Escape menu buttons now actually take a hud_owner #89878

Merged

XeonMations mentioned this pull request May 30, 2025

Interaction code cleanup, attempt 2 The-Final-Nights/The-Final-Nights#466

Merged

57 tasks

Absolucy mentioned this pull request Jun 14, 2025

Fixes up lobby screen fading out + roundstart storyteller Monkestation/Monkestation2.0#6991

Merged

Absolucy mentioned this pull request Jun 14, 2025

Fix the lobby art not fading out #91637

Merged

twilightwanderer mentioned this pull request Jun 16, 2025

[TG Mirror] Fix the lobby art not fading out [MDB IGNORE] Alliance-Station/Alliance-Station#17

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hud screens now set hud owner in Initialize. #76772

Hud screens now set hud owner in Initialize. #76772

Uh oh!

JohnFulpWillard commented Jul 12, 2023 •

edited

Loading

Uh oh!

Uh oh!

Hud screens now set hud owner in Initialize. #76772

Hud screens now set hud owner in Initialize. #76772

Uh oh!

Conversation

JohnFulpWillard commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About The Pull Request

Why It's Good For The Game

Changelog

Uh oh!

Uh oh!

JohnFulpWillard commented Jul 12, 2023 •

edited

Loading