Massively optimizes dmi_icon_states
#209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeWaka
approved these changes
Mar 14, 2025
itsmeow
pushed a commit
to itsmeowForks/rust-g
that referenced
this pull request
Mar 31, 2025
itsmeow
added a commit
to BeeStation/rust-g
that referenced
this pull request
Mar 31, 2025
* Routine Update PR (tgstation#167) * Standardize redis_reliablequeue connect/disconnect output (tgstation#150) * More routine updates (tgstation#169) * IconForge - Building spritesheets at the speed of light (tgstation#160) * iconforge beta * Start blending * Huge cleanup * Finish optimizing the thing * Finish the thing!! * Clean up a bit * Re-add 32-bit thing * Fix TOML sorting * Add dmsrc * Fix clippy suggestions * Clippy.. stop being mean * Cargo fmt + doc comments * Code cleanup * More cleanup, remove most unsafe unwrap()s, use Match syntax. * Remove unneccesarily verbose casting * Fix overlay blending * Cleanup with new DMI version * Cargo fmt * Leaf test, DynamicImage->RgbaImage, better Error handling, DashMap, and cleanup command * Fix * Further tree optimizations, hashing optimization, cache icostrings more effectively. * Optimize unique_icons insertion a little * Fix macro * Little more cleanup * Add to README * Update dmi, add caching logic. * Address reviews * Cleanup panic unwind * Fix lint failure * Fix bounds expansion crops, and properly index crops from 1,1 * Don't multiply by alpha if the base alpha is 0 * Fix subtract blending * Don't hash the same DMI 500 times * Address reviews * Clippy fix * v3.2.0 (tgstation#170) * Adds `sanitize_html`, a whitelist based HTML sanitizer. (tgstation#171) * Adds batchnoise to the default features set (tgstation#174) * Typical Routine Updates (tgstation#175) * Add task for building on windows (tgstation#176) * v3.3.0 (tgstation#177) * Fast poisson sampling (tgstation#178) Co-authored-by: ZeWaka <[email protected]> * Add format argument to git revdate ffi (tgstation#179) * Add method of parsing revdate for HEAD directly from logs (tgstation#180) * use lines not split (tgstation#181) * Windows 7 (tgstation#183) * Allow compiling non-32bit under feature flag (tgstation#184) Co-authored-by: ZeWaka <[email protected]> * 32bit readme (tgstation#186) * v3.4.0 (tgstation#187) * Fix a panic in `byond::parse_args` with debug assertions (tgstation#189) * chore: routine updates (tgstation#190) * more assorted package updates because bored (tgstation#191) * last-minute updates (tgstation#193) * v3.5.0 (tgstation#194) * iconforge: Use height() for y axis to support non-square icons (tgstation#197) * Add building of x64 libs to CI (tgstation#200) * Add hash and iconforge as default features (tgstation#196) * IconForge: GAGS (tgstation#188) * 64 bit lib detection (tgstation#202) * update mysql crate, trims a lot of deps (tgstation#203) * Reset to correct versions * IconForge: Sort GAGS output states (tgstation#206) * IconForge: Improve GAGS frame/dir difference handling (tgstation#207) * gamer release workflow * v3.7.0 (tgstation#208) * Fix release upload paths * fully correct and rename files in CI/CD * Massively optimizes `dmi_icon_states` (tgstation#209) * Add support for timing out HTTP calls (tgstation#210) * v3.8.0 (tgstation#211) * fix default release name while i remember * Feature: rustg_sound_length() (tgstation#192) * update `rand` to `0.9`, `cargo update` (tgstation#204) * Adjust CI to match our workflow * Fix outdated upload-artifact version --------- Co-authored-by: ZeWaka <[email protected]> Co-authored-by: Kapu1178 <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: Fluffy <[email protected]> Co-authored-by: Zephyr <[email protected]> Co-authored-by: Mothblocks <[email protected]> Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: Lucy <[email protected]> Co-authored-by: tigercat2000 <[email protected]> Co-authored-by: Amy <[email protected]> Co-authored-by: Jordan Dominion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports my dmi icon state parser from https://github.com/Absolucy/icon-presence-cache - which just directly reads the (quite simple) zTXT header, rather than using the
dmicrate - which will decode all the image data too, despite the fact we don't need any of that in order to just list the icon states.icon-presence-cacheis capable of parsing the icon states of every single .dmi on tgstation master in 1.8 seconds, while it took 3.5 seconds using thedmi::Iconapproach, so this should be plenty fast.