Use tokenize instead of getTokenizer #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
あー、ごめんなさい。 #23 の変更でconflictしてしまいました。 |
|
あー、了解です。今週末にrebaseしてpushしておきます。 |
azu
reviewed
Aug 13, 2022
src/no-doubled-conjunction.js
Outdated
| }; | ||
| report(node, new RuleError(`同じ接続詞（${conjunctionSurface}）が連続して使われています。`, padding)); | ||
| } | ||
| return Promise.all(sentences.map(selectConjenction)).reduce((prev, current) => { |
There was a problem hiding this comment.
Promiseに対してreduceしちゃってるっぽいですね。
const results = await Promise.all(sentences.map(selectConjenction));的な感じですかね。
There was a problem hiding this comment.
あと、 [].reduce(() => {}) は例外を投げるので、resultsが空の場合をチェックするか、reduceの第二引数を指定するかがありそうです。
(いま思うと、別に値を返してないので、reduceじゃなくても良いかもですね)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ルール間で形態素解析結果を使いまわせるように
tokenizeを使用するPRです。