Skip to content

NetworkImpl.NetworkImplBuilder should not allow to reassign id() #2185

Closed
@leventov

Description

@leventov

NetworkImpl.NetworkImplBuilder should not allow to reassign id() because it will have no effect on the actual id.

Also, strictly speaking, close() may not see the id value if called from another thread than getId(). To ensure that, close() method should be synchronized as well as getId(). I'm not sure how relevant this is, but since getId() is synchronized itself it might be.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions