Skip to content

update robotframework-appiumlibrary to latest version to fix its dependencies issues #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ngoan1608
Copy link
Collaborator

@ngoan1608 ngoan1608 commented Jun 24, 2024

Hi Thomas,

I observed that robotframework-appiumlibrary library has released new version 2.1.0 2 weeks ago after long time without release (the previous release 2.0.0 is since Nov 2022).
This release solves a lot of issues which includes the incompatible issues of Python-Appium-Client (that I have to fix version in our build) and selenium (as issue #274) .
https://github.com/serhatbolsu/robotframework-appiumlibrary/releases

So that I updated python requirements file to use the latest version of robotframework-appiumlibrary for our AIO package.

Thank you,
Ngoan

@ngoan1608 ngoan1608 force-pushed the ntd1hc/bug/274-known-issue-of-robotframework-appiumlibrary-due-to-incompatible-version-of-current-selenium-versions branch from 4788110 to 4b4f75c Compare June 24, 2024 07:24
Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ngoan,
looks good to me!
Thank you,
Thomas

@ngoan1608
Copy link
Collaborator Author

HI @ngoan1608 , How to I get this out of DRAFT state? This way I can't merge. Thank you, Thomas

Hi Thomas,

I make is as draft state because I am verifying the change from side.
After the verification is fine, I will make it ready for review and merge.

Thank you,
Ngoan

@test-fullautomation
Copy link
Owner

O.K.

The VSCodium-Version pull-request I already merged.

@ngoan1608 ngoan1608 marked this pull request as ready for review June 24, 2024 10:06
@ngoan1608
Copy link
Collaborator Author

Hi Thomas,

I have verified from my side and now make this PR ready for review.

Thank you,
Ngoan

@test-fullautomation test-fullautomation merged commit 5b4abb0 into develop Jun 24, 2024
9 checks passed
@test-fullautomation test-fullautomation added this to the 0.12.1 milestone Jun 24, 2024
@test-fullautomation test-fullautomation added enhancement New feature or request and removed ready for testing labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.12.1 enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants