Skip to content

Bug fix for core mesh params + nonUniformAssems #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

albeanth
Copy link
Member

@albeanth albeanth commented Nov 17, 2022

Description

A bug was found for the core mesh params referenceBlockAxialMesh and axialMesh when considering assemblies that have the nonUniformAssem flag.

These core params should not include nonUniformAssems. This PR resolves this.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
    • I think we should create an issue to make updating/setting core.p.referenceAxialMesh and core.p.axialMesh consistent and specifically testable.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@albeanth albeanth added the bug Something is wrong: Highest Priority label Nov 17, 2022
@albeanth albeanth marked this pull request as draft November 17, 2022 23:05
@albeanth albeanth marked this pull request as ready for review November 23, 2022 20:05
@jakehader jakehader merged commit 83acb89 into terrapower:main Nov 30, 2022
@albeanth albeanth deleted the nonUniformAssem_ProcessLoadFix branch December 15, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants