thKernel data type fix

[daleazer]

What is the change?

The thKernel setting is meant to store the name of the primary thermal hydraulics solver for a run. The default value was False, causing the data type of thKernel to be bool. When a user set the value of thKernel to anything in the settings file, it would only be set to True. Changing the default value to an empty string changes its data type to str, allowing the setting to work as originally intended.

This change resolves issue #1854.

Why is the change being made?

This change is necessary to allow the thKernel setting to work as intended. Without this change, the thKernel can only be set to boolean values. With this change, thKernel can be set to any string.

---

Checklist

• This PR has only one purpose or idea.
• Tests have been added/updated to verify any new/changed code.
• The code style follows good practices.
• The commit message(s) follow good practices.
• The release notes have been updated if necessary.
• The documentation is still up-to-date in the doc folder.
• The dependencies are still up-to-date in pyproject.toml.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ john-science
❌ daleazer
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[john-science]

@daleazer Welcome aboard! Do I happen to know you, IRL?

The change itself seems pretty reasonable. I am only surprised to see it, because I didn't think anyone actually used the thKernel setting.

(Oh, it looks like you have some linting and things to clean up.)

[john-science]

@daleazer Can you add this header to the empty __init__.py file you created:

# Copyright 2024 TerraPower, LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Thanks!

[daleazer]

Thank you! I don't believe we know each other.

I have added the license text to __init__.py. Was there anything else?

[john-science]

Thank you! I don't believe we know each other.

I have added the license text to __init__.py. Was there anything else?

The black linting is still broken. Can you run black on your PR and merge it again? Thanks!

[daleazer]

Thank you! I don't believe we know each other.
I have added the license text to __init__.py. Was there anything else?

The black linting is still broken. Can you run black on your PR and merge it again? Thanks!

Should be fixed now

[john-science]

Love it! Thanks!