Skip to content

Cleaning out unused code and adding coverage #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 5, 2024
Merged

Conversation

john-science
Copy link
Member

@john-science john-science commented Aug 29, 2024

What is the change?

This is just a general cleanup PR.

  1. Removed prepSearch(), which was fully deprecated years ago, and verified that it wasn't used anywhere downstream.
  2. Removed a strange staticmethod SkippingXsGen_BuChangedLessThanTolerance, which was fundamentally unused.
  3. Fixed the interactBOL test in DB interface to stop leaving test crumbs (FINALLY, this took a long time to find).
  4. Moved two functions that were inside the FuelHandler.getAssembly() out of that function, to make them testable.
  5. Added a ton some generic code coverage.

Why is the change being made?

I just ran afoul of the deprecated function, and wanted to do some cleanup.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Aug 29, 2024
@john-science john-science requested a review from opotowsky August 29, 2024 22:49
@albeanth
Copy link
Member

If I could make 1 request, I know you grepped around, but please run this on the testing suite for an internal TP App before merging. Thank you, @john-science !

Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! (I do echo Tony's request, though.)

@john-science
Copy link
Member Author

If I could make 1 request, I know you grepped around, but please run this on the testing suite for an internal TP App before merging. Thank you, @john-science !

I will do that, sure!

@john-science
Copy link
Member Author

@opotowsky @albeanth Okay, I tested this downstream with the usual battery of cross-platform testing. It looks good!

@opotowsky
Copy link
Member

@opotowsky @albeanth Okay, I tested this downstream with the usual battery of cross-platform testing. It looks good!

Merge away! 🚀

@john-science john-science merged commit f5267e0 into main Sep 5, 2024
21 checks passed
@john-science john-science deleted the cleanup_20240828 branch September 5, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants