-
Notifications
You must be signed in to change notification settings - Fork 94
Cleaning out unused code and adding coverage #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If I could make 1 request, I know you grepped around, but please run this on the testing suite for an internal TP App before merging. Thank you, @john-science ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!! (I do echo Tony's request, though.)
I will do that, sure! |
@opotowsky @albeanth Okay, I tested this downstream with the usual battery of cross-platform testing. It looks good! |
Merge away! 🚀 |
What is the change?
This is just a general cleanup PR.
prepSearch()
, which was fully deprecated years ago, and verified that it wasn't used anywhere downstream.SkippingXsGen_BuChangedLessThanTolerance
, which was fundamentally unused.interactBOL
test in DB interface to stop leaving test crumbs (FINALLY, this took a long time to find).FuelHandler.getAssembly()
out of that function, to make them testable.Why is the change being made?
I just ran afoul of the deprecated function, and wanted to do some cleanup.
Checklist
doc
folder.pyproject.toml
.