Skip to content

Add copyOutput option to globalFluxInterface #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 29, 2023

Conversation

mgjarrett
Copy link
Contributor

@mgjarrett mgjarrett commented Mar 20, 2023

Description

Add option not to copy the output back from globalFluxInterface.

Sometimes the globalFluxInterface is only run to get a k-eigenvalue for a given case. Even if this is the case, the globalFluxInterface will still copy the full output from the physics kernel back to the working directory, which can be 50 MB+. When running many hundreds or thousands of cases to calculate k-effective from various perturbations, this generates an unwieldly number and total size of output files that aren't needed. The noOutput option would allow a case to call the globalFluxInterface, grab k-effective from the output, and then skip the step of copying it back to the working directory.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@mgjarrett mgjarrett added the enhancement New feature or request label Mar 20, 2023
@mgjarrett
Copy link
Contributor Author

Only a single line was added, and it is in an __init__ function that is already covered. No new unit tests are needed to cover this feature.

@mgjarrett mgjarrett marked this pull request as ready for review March 21, 2023 04:02
@mgjarrett mgjarrett requested a review from albeanth March 21, 2023 04:02
@albeanth
Copy link
Member

@mgjarrett and I are currently discussing the effects this has on downstream applications. Once that has been settled, we will move forward with this PR.

copyOutput (default True) instead of noOutput (default False)
@albeanth albeanth changed the title Add noOutput option to globalFluxInterface Add copyOutput option to globalFluxInterface Mar 23, 2023

In some ARMI runs, the executer can be run hundreds or thousands of times and generate many output files that
aren't strictly necessary to keep around. One can save space by choosing not to copy the outputs back in these
special cases. extraOutputFiles are typically controlled by the subclass, so
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring looks incomplete?

@mgjarrett mgjarrett requested a review from albeanth March 28, 2023 18:01
@mgjarrett mgjarrett merged commit 2a3a892 into terrapower:main Mar 29, 2023
@mgjarrett mgjarrett deleted the noOutput branch March 29, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants