-
Notifications
You must be signed in to change notification settings - Fork 94
Add copyOutput option to globalFluxInterface #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only a single line was added, and it is in an |
@mgjarrett and I are currently discussing the effects this has on downstream applications. Once that has been settled, we will move forward with this PR. |
copyOutput (default True) instead of noOutput (default False)
armi/physics/executers.py
Outdated
|
||
In some ARMI runs, the executer can be run hundreds or thousands of times and generate many output files that | ||
aren't strictly necessary to keep around. One can save space by choosing not to copy the outputs back in these | ||
special cases. extraOutputFiles are typically controlled by the subclass, so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring looks incomplete?
Description
Add option not to copy the output back from globalFluxInterface.
Sometimes the
globalFluxInterface
is only run to get a k-eigenvalue for a given case. Even if this is the case, theglobalFluxInterface
will still copy the full output from the physics kernel back to the working directory, which can be 50 MB+. When running many hundreds or thousands of cases to calculate k-effective from various perturbations, this generates an unwieldly number and total size of output files that aren't needed. ThenoOutput
option would allow a case to call theglobalFluxInterface
, grab k-effective from the output, and then skip the step of copying it back to the working directory.Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.