Fission Product Model with Explicit Fission Products for all Depletable Components #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclides were not being initialized in non-fuel depletable components when using the `explicitFissionProducts` model. Add testing for the updated implementation.
…nProductFixupNonFuel
mgjarrett
reviewed
Jan 5, 2023
armi/physics/neutronics/fissionProductModel/fissionProductModel.py
Outdated
Show resolved
Hide resolved
mgjarrett
requested changes
Jan 5, 2023
john-science
reviewed
Jan 5, 2023
armi/physics/neutronics/fissionProductModel/fissionProductModel.py
Outdated
Show resolved
Hide resolved
mgjarrett
reviewed
Jan 5, 2023
armi/physics/neutronics/fissionProductModel/fissionProductModel.py
Outdated
Show resolved
Hide resolved
mgjarrett
reviewed
Jan 6, 2023
armi/physics/neutronics/fissionProductModel/fissionProductModel.py
Outdated
Show resolved
Hide resolved
…power/armi into fissionProductFixupNonFuel
…nProductFixupNonFuel
…face to only run coupled cross section generation at time node 0.
… fissionProductFixupNonFuel
mgjarrett
approved these changes
Jan 8, 2023
|
This PR had an issue on Linux, where file paths are case sensitive. I edited the files / expected paths to be upper case, as is currently defined as the default. But now there are a mix of upper and lower case file path extensions in the test files. So as not to force this PR to solve even more problems, I made an issue about it: #1078 |
opotowsky
approved these changes
Jan 9, 2023
7 tasks
mgjarrett
reviewed
Jan 11, 2023
| @@ -1,6 +1,3 @@ | |||
| *isotxs* | |||
| *gamiso* | |||
| *pmatrx* | |||
There was a problem hiding this comment.
In retrospect this maybe didn't need to change. But also, it maybe wasn't necessary to have these in the .gitignore in the first place, so it's not clear that it's a problem.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the fission product model to fix a bug where all nuclides were not being initialized in non-fuel depletable components when using the
explicitFissionProductsmodel. Add testing for the updated implementation.It also ensures dummy nuclides are added for all XS types during
mergeXSLibrariesInWorkingDirectory, with added testing.Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.