Skip to content

fix(zed, zed-nightly, zed-preview): Make compatible with ZFS #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: frawhide
Choose a base branch
from

Conversation

RockGrub
Copy link
Member

Fixes #5569.

@RockGrub RockGrub disabled auto-merge June 18, 2025 19:02
@RockGrub RockGrub changed the title Gil/fix/zed fix(zed, zed-nightly, zed-preview): Make compatible with ZFS Jun 18, 2025
@RockGrub RockGrub enabled auto-merge (squash) June 18, 2025 19:03
@madonuko
Copy link
Member

subpackage that provides the correctly binary name with symlink? and make that conflicts with zfs

@RockGrub
Copy link
Member Author

subpackage that provides the correctly binary name with symlink? and make that conflicts with zfs

We already renamed the cli crate when it was installed, does Zed specifically look for it under the zed name?

@madonuko
Copy link
Member

idrk tbh

@RockGrub
Copy link
Member Author

RockGrub commented Jun 19, 2025

Slight issue with that as well, the zed executable is not part of a package and seems to simply be a part of the ZFS filesystem itself. There is nothing I can make it conflict with.

@madonuko
Copy link
Member

is upstream renaming it to zeditor? maybe we should do the same?

also, the issue mentioned dnf install zfs so I assumed we could just conflict that package specifically

@RockGrub
Copy link
Member Author

Yeah I was confused about that too? But ZFS is an entire filesystem.

But also the issue isn't the editor, we've been renaming that the whole time, it's the CLI component binary, are they doing anything with that? I didn't see anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] zed editor name classes with zed from zfs
2 participants