Fix: Add depends_on in ingress policies resources #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the addition of a depends_on with the resources that add projects to the perimeter, in the resources that create ingress policies, correcting the error generated by the VPC Service Controls module when it needs to add a project to the perimeter, and create an ingress rule for the same project, at the same time.
Error: Error creating ServicePerimeterIngressPolicy: googleapi: Error 400: Invalid Directional Policies set in Perimeter 'accessPolicies/ACCESS_CONTEXT_MANAGER_ID/servicePerimeters/SERVICE_PERIMETER_NAME': Error in IngressTo: 'projects/PROJECT_NUMBER is defined in
IngressTo.resources, but it is not present inServicePerimeterConfig.resources. Only resources protected by this Service Perimeter can be put in IngressTo.resources.With the addition of this depends_on, the module will always add the project before creating the ingress policy for it.