Skip to content

fix: use dry run resource to add resources to the perimeter #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 11, 2025
Merged

fix: use dry run resource to add resources to the perimeter #204

merged 6 commits into from
Jun 11, 2025

Conversation

daniel-cit
Copy link
Contributor

This PR use the dry run resource google_access_context_manager_service_perimeter_dry_run_resource to add resources to the perimeter in dry-run mode

@daniel-cit daniel-cit requested review from imrannayer and a team as code owners June 10, 2025 18:07
@apeabody apeabody self-assigned this Jun 10, 2025
@daniel-cit
Copy link
Contributor Author

/gcbrun

1 similar comment
@daniel-cit
Copy link
Contributor Author

/gcbrun

@daniel-cit
Copy link
Contributor Author

@apeabody could you PTAL?

apeabody
apeabody approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit!

@apeabody apeabody merged commit afa9c35 into terraform-google-modules:main Jun 11, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-cit @apeabody