-
Notifications
You must be signed in to change notification settings - Fork 70
feat: Add scopes, update directional rules variable definition and dry-run lifecycle ignore_changes
#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
apeabody
merged 16 commits into
terraform-google-modules:main
from
daniel-cit:fix-directional-rules
Jun 3, 2025
Merged
feat: Add scopes, update directional rules variable definition and dry-run lifecycle ignore_changes
#199
apeabody
merged 16 commits into
terraform-google-modules:main
from
daniel-cit:fix-directional-rules
Jun 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore_changes
ignore_changes
Need to add the golang tests to the integration build |
ignore_changes
ignore_changes
amandakarina
approved these changes
Jun 3, 2025
apeabody
requested changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniel-cit! Two minor notes
apeabody
reviewed
Jun 3, 2025
apeabody
reviewed
Jun 3, 2025
apeabody
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniel-cit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds supports for
scopes
in the access policy and fixes two issues:spec
version ofresources
,ingress_policies
, andegress_policies
were not in thelifecycle.ignore_changes
configuration causing conflict with usage ofgoogle_access_context_manager_service_perimeter_dry_run_egress_policy
andgoogle_access_context_manager_service_perimeter_dry_run_ingress_policy