Skip to content

feat!: Update for TF and CI, add instance test #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2022
Merged

feat!: Update for TF and CI, add instance test #59

merged 1 commit into from
Jul 29, 2022

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Jul 26, 2022

Fixes #54
Fixes #34
The instance sub-module now includes instance_id as an output.

@apeabody apeabody marked this pull request as draft July 28, 2022 20:12
@apeabody apeabody changed the title fix: multiple updates for TF and CI fix: Update for TF and CI, add instance test Jul 28, 2022
@apeabody apeabody changed the title fix: Update for TF and CI, add instance test feat!: Update for TF and CI, add instance test Jul 28, 2022
@apeabody apeabody marked this pull request as ready for review July 29, 2022 16:00
@apeabody apeabody requested a review from bharathkkb July 29, 2022 16:01
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these @apeabody

* Update minimum TF to 0.13, TPG to 4.12, and TF modultes
* Update to CFT 1.5
* Convert template simple_example test to new instance test
* Update tenant_project output method
* Update instance example functionality
@comment-bot-dev
Copy link

@apeabody
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody merged commit 77fa12c into terraform-google-modules:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.1.0] The DF instance is not compatible to terraform version 0.13 data_fusion_service_account variable is not used
3 participants