Skip to content

feat: support data fusion version #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2022
Merged

feat: support data fusion version #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
070e805
Fixed Issue #51
abalasub1312 Jul 11, 2022
dbf5868
Fixed Issue #51 and generated docs
abalasub1312 Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Functional examples are included in the
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| data\_fusion\_service\_account | Google Managed Data Fusion Service Account Email | `any` | n/a | yes |
| datafusion\_version | Data Fusion Version to deploy. | `string` | `null` | no |
| dataproc\_subnet | Name for subnet to create and configure for Dataproc clusters controlled by private Data Fusion instance. | `string` | `"dataproc-subnet"` | no |
| description | An optional description of the instance. | `string` | `null` | no |
| labels | The resource labels for instance to use to annotate any related underlying resources, such as Compute Engine VMs. | `map(string)` | `{}` | no |
Expand Down
1 change: 1 addition & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ module "instance" {
region = var.region
type = var.type
labels = var.labels
datafusion_version = var.datafusion_version
options = var.options
network_config = {
network = module.data_fusion_network.data_fusion_vpc.network_name
Expand Down
1 change: 1 addition & 0 deletions modules/instance/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ resource "google_data_fusion_instance" "instance" {
enable_stackdriver_logging = true
enable_stackdriver_monitoring = true
labels = var.labels
version = var.datafusion_version
options = var.options
private_instance = var.network_config != null

Expand Down
6 changes: 6 additions & 0 deletions modules/instance/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ variable "project" {
type = string
}

variable "datafusion_version" {
description = "Data Fusion Version to deploy."
type = string
default = null
}

variable "description" {
description = "An optional description of the instance."
type = string
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ variable "project" {
type = string
}

variable "datafusion_version" {
description = "Data Fusion Version to deploy."
type = string
default = null
}

variable "network" {
description = "Name for VPC to create or reuse to be configured for use with private Data Fusion instance."
type = string
Expand Down