-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fed 15439 vdoorman replica version bump #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tyleratverkada
wants to merge
20
commits into
terraform-aws-modules:master
from
verkada:FED-15439_vdoorman_replica_version_bump
Closed
Fed 15439 vdoorman replica version bump #555
tyleratverkada
wants to merge
20
commits into
terraform-aws-modules:master
from
verkada:FED-15439_vdoorman_replica_version_bump
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-rds 2021-04-24T08:46:01Z aab1bff Updated CHANGELOG 96de19f fix: mark sensitive outputs to support Terraform 0.15.x (terraform-aws-modules#329) a853247 chore: update documentation and pin `terraform_docs` version to avoid future changes (terraform-aws-modules#323)
* upgrading for hashicorp/aws version 4+
Upgrade to AWS provider v5
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vdoorman needed to bump a version for postgres, but on the replica, we need to ensure that we can update both versions of the master and the replica in the same commit.
Code here was to fallback on version numbers to grab the version of the master, but we need to enforce that upgrade works for both instances if the version needs to change.
Also made this apply to the engine itself, just in case that is needed in the future.
Motivation and Context
We need to update version numbers on a cluster for postgres.
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request