Support for Mixed Instances ASG in worker_groups_launch_template variable

[sppwf]

PR o'clock

Description

Added support for Mixed Instances ASG in worker_groups_launch_template variable.
Changed the local.asg_tags - tag generation using for utility from terraform 12
worker_groups_launch_template_mixed variable left for backward compatibility

Checklist

• terraform fmt and terraform validate both work from the root and examples/* directories
• CI tests are passing
• I've added my change to CHANGELOG.md and highlighted any breaking changes
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[max-rocket-internet]

If I understand correctly, we could remove anything related to workers_launch_template_mixed, right? That would be super cool 🙌

[sppwf]

Yes, we can remove, however i just left it for backward compatibily.
Either we just create some migration plan, not sure how you guys used to do here.

Thanks
Sergiu

[max-rocket-internet]

Yes, we can remove, however i just left it for backward compatibily.

Great! Then please, if you can, do remove the launch template mixed related stuff. It was created as there was no other option in TF 0.11 but it would be much simpler and tidier if we just had workers_launch_template that covered all needs 🚀

[sppwf]

@max-rocket-internet Should i do here something more, I am a little bit confuzed ?

[max-rocket-internet]

Just give me more time to have a look, it's quite a big change 😅

[max-rocket-internet]

I just tested this by running TF from examples/spot_instances but the ASG doesn't have any of the instance type overrides added:

[sppwf]

I was looking for this variable to be configured on_demand_allocation_strategy, however, specifing override_instance_types with some values means user will want spot instances.

[max-rocket-internet]

I tested again.

From examples/spot_instances:

module.eks.aws_autoscaling_group.workers_launch_template[0]: Creating...

Error: Error creating AutoScaling Group: ValidationError: Valid requests must contain either LaunchTemplate, LaunchConfigurationName, InstanceId or MixedInstancesPolicy parameter.
	status code: 400, request id: 33c4d651-d2f1-11e9-89e0-f7c70abdf77c

  on ../../workers_launch_template.tf line 3, in resource "aws_autoscaling_group" "workers_launch_template":
   3: resource "aws_autoscaling_group" "workers_launch_template" {

From examples/launch_templates:

module.eks.aws_autoscaling_group.workers_launch_template[1]: Creating...
module.eks.aws_autoscaling_group.workers_launch_template[0]: Creating...

Error: Error creating AutoScaling Group: ValidationError: Valid requests must contain either LaunchTemplate, LaunchConfigurationName, InstanceId or MixedInstancesPolicy parameter.
	status code: 400, request id: 35bb4f82-d2f1-11e9-ba6a-8da9e1bac398

  on ../../workers_launch_template.tf line 3, in resource "aws_autoscaling_group" "workers_launch_template":
   3: resource "aws_autoscaling_group" "workers_launch_template" {



Error: Error creating AutoScaling Group: ValidationError: Valid requests must contain either LaunchTemplate, LaunchConfigurationName, InstanceId or MixedInstancesPolicy parameter.
	status code: 400, request id: 35bb28fd-d2f1-11e9-ae7d-c78bc1196371

  on ../../workers_launch_template.tf line 3, in resource "aws_autoscaling_group" "workers_launch_template":
   3: resource "aws_autoscaling_group" "workers_launch_template" {

[max-rocket-internet]

Could you run terraform apply & terraform destroy from all 3 examples to ensure it works?

Really keen to get this PR merged though as it removes a lot of duplication 😄

[sppwf]

Mr @max-rocket-internet :)
Please check the flow now. it worked for me

[max-rocket-internet]

OK! I tested it and it looks good. Can you resolve conflict and the we can merge?

[max-rocket-internet]

Thanks @sppwf !

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.