feat: Use vpc cidr for efs sg unless overridden

[nitrocode]

Description

• Use vpc cidr for efs sg unless overridden

Motivation and Context

• The module allows passing in a cidr to create a vpc and use that same cidr as ingress_cidr_blocks to the efs sg.
• If a vpc_id is passed in, the hcl will still use the cidr input to set the efs sg
• This change will continue to let cidr input as the efs sg ingress cidr blocks but if it is left empty (default), the efs sg ingress cidr blocks will default to the vpcs cidr, either the vpc passed in or the vpc created.

Breaking Changes

N/A

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

references

• Thanks to @bodgit for the original fix in bodgit@54bd2d9
• Closes Error with EFS security group if using existing VPC #252

[dynamike]

Dropped a comment on just removing the cidr ingress rule.

[dynamike]

Looking at this whole security group makes me think that you don't need to allow ingress to the EFS volume from the entire VPC. Instead we can just rely on https://github.com/terraform-aws-modules/terraform-aws-atlantis/blob/master/main.tf#L387-L390, which already allows nfs-tcp from the Atlantis security group.

[dynamike]

Closing in favor of #318

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.