fix: Set correct default for runtime_platform to ensure idempotence #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affelaffen
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Jun 22, 2022
### [3.17.1](v3.17.0...v3.17.1) (2022-06-22) ### Bug Fixes * set correct default for runtime_platform variable to ensure idempotence ([#291](#291)) ([96c8613](96c8613))
|
This PR is included in version 3.17.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the default value for the
runtime_platformto avoid recreation of theaws_ecs_task_definitionon every apply when not specifying anyruntime_platformvalues. Since the dynamic block for theruntime_platformchecks if the variable is null before trying to set a value and the current default value is set to an empty map, it will always try to add an empty map to the task definition. This causes terraform to consider it a change, which forces replacement of both theaws_ecs_task_definitionand theaws_ecs_service.Motivation and Context
The issue was introduced in #279, which added this support for runtime_platform.
Breaking Changes
No breaking changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request