feat: Add var.task_execution_session_duration for task execution role #251
Conversation
itmustbejj
force-pushed
the
feat/execution-role-session-duration
branch
2 times, most recently
from
992702f to
b80c922
Compare
variables.tf
Outdated
| @@ -672,3 +672,14 @@ variable "ephemeral_storage_size" { | |||
| error_message = "The minimum supported value is 21 GiB and the maximum supported value is 200 GiB." | |||
| } | |||
| } | |||
|
|
|||
| variable "task_execution_session_duration" { | |||
There was a problem hiding this comment.
lets do the following please:
variable "max_session_duration" {
description = "Maximum session duration (in seconds) that you want to set for the specified role. Default is 3600"
type = number
default = null
}Note - you'll need to rename the variable above in main.tf
There was a problem hiding this comment.
@bryantbiggs thanks for the prompt feedback. That should be all set.
There was a problem hiding this comment.
Also, please fix the docs by running pre-commit run -a and committing the changes.
itmustbejj
force-pushed
the
feat/execution-role-session-duration
branch
4 times, most recently
from
501861d to
3c4afd9
Compare
There was a problem hiding this comment.
thanks for the PR @itmustbejj !
@antonbabenko should be good to go 👍🏽
|
sorry to hear your plans take that long - might want to think about splitting up that statefile 😅 |
|
We use terragrunt so the state files are already split up pretty judiciously. The specific use case here is around long-running sync jobs. I have ideas for the next refactor, but you know how that goes... |
|
This PR has been automatically marked as stale because it has been open 30 days |
itmustbejj
force-pushed
the
feat/execution-role-session-duration
branch
from
3c4afd9 to
105c7ba
Compare
|
@antonbabenko @bryantbiggs apologies for the delay. I rebased my PR and updated the README via |
itmustbejj
force-pushed
the
feat/execution-role-session-duration
branch
from
105c7ba to
99ac322
Compare
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add
var.task_execution_session_durationfor task execution role.https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role
Motivation and Context
The default max_session_duration for iam roles of 1 hour is insufficient for long-running terraform applies. This leads to runs breaking and failing to persist their state in s3, and often requires painful manual cleanup.
Breaking Changes
None
How Has This Been Tested?
examples/*projects