Skip to content

feat: Allow for an existing ECS cluster to be used #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 11, 2022
Merged

feat: Allow for an existing ECS cluster to be used #233

merged 10 commits into from
Feb 11, 2022

Conversation

henworth
Copy link
Contributor

@henworth henworth commented Nov 3, 2021

Description

Provide the ability to use an existing ECS cluster instead of making one.

Motivation and Context

Allow for the use of an existing cluster if there is a desire or requirement to do so.

Breaking Changes

None.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

Ran this in my own environment to build my Atlantis instance using my existing cluster. This also passes all of the pre-commit tests.

bryantbiggs
bryantbiggs reviewed Nov 3, 2021
View reviewed changes
bryantbiggs
bryantbiggs requested changes Nov 3, 2021
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of checking for empty strings, lets add a variable create_ecs_clsuter and set the default to true. then anywhere you are doing var.ecs_cluster_id == "" will simply be var.create_ecs_cluster

bryantbiggs
bryantbiggs reviewed Nov 3, 2021
View reviewed changes
@henworth henworth changed the title Allow for an existing ECS cluster to be used feat: Allow for an existing ECS cluster to be used Nov 4, 2021
bryantbiggs
bryantbiggs reviewed Jan 6, 2022
View reviewed changes
@bryantbiggs
Copy link
Member

everything checks out for this PR - if we can just address the one detail listed above we should be good to go - thanks @henworth and apologies for the delay

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 6, 2022
@henworth
Copy link
Contributor Author

@bryantbiggs no problem, I've reverted that output removal

@bryantbiggs
Copy link
Member

@henworth looks like you need to run pre-commit run -a one last time to fix the docs - otherwise should be good to go @antonbabenko

@henworth
Copy link
Contributor Author

oops, fixed @bryantbiggs

bryantbiggs
bryantbiggs approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @henworth - good to go @antonbabenko 👍🏽

@antonbabenko antonbabenko merged commit 6b7594a into terraform-aws-modules:master Feb 11, 2022
antonbabenko pushed a commit that referenced this pull request Feb 11, 2022
@semantic-release-bot
chore(release): version 3.12.0 [skip ci]
2df6bd6 
## [3.12.0](v3.11.0...v3.12.0) (2022-02-11)

### Features

* Allow for an existing ECS cluster to be used ([#233](#233)) ([6b7594a](6b7594a))
@antonbabenko
Copy link
Member

This PR is included in version 3.12.0 🎉

titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022
@henworth
feat: Allow for an existing ECS cluster to be used (terraform-aws-mod…
5524abf 
…ules#233)
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022
@semantic-release-bot
chore(release): version 3.12.0 [skip ci]
82553e6 
## [3.12.0](terraform-aws-modules/terraform-aws-atlantis@v3.11.0...v3.12.0) (2022-02-11)

### Features

* Allow for an existing ECS cluster to be used ([terraform-aws-modules#233](terraform-aws-modules#233)) ([6b7594a](terraform-aws-modules@6b7594a))
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022
@henworth
feat: Allow for an existing ECS cluster to be used (terraform-aws-mod…
60f7d9c 
…ules#233)
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 8, 2022
@semantic-release-bot
chore(release): version 3.12.0 [skip ci]
8e63409 
## [3.12.0](terraform-aws-modules/terraform-aws-atlantis@v3.11.0...v3.12.0) (2022-02-11)

### Features

* Allow for an existing ECS cluster to be used ([terraform-aws-modules#233](terraform-aws-modules#233)) ([6b7594a](terraform-aws-modules@6b7594a))
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 9, 2022
@henworth
feat: Allow for an existing ECS cluster to be used (terraform-aws-mod…
99ec12e 
…ules#233)
titanlien pushed a commit to Flaconi/terraform-aws-atlantis that referenced this pull request Jun 9, 2022
@semantic-release-bot
chore(release): version 3.12.0 [skip ci]
228ce9e 
## [3.12.0](terraform-aws-modules/terraform-aws-atlantis@v3.11.0...v3.12.0) (2022-02-11)

### Features

* Allow for an existing ECS cluster to be used ([terraform-aws-modules#233](terraform-aws-modules#233)) ([6b7594a](terraform-aws-modules@6b7594a))
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko left review comments

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henworth @bryantbiggs @antonbabenko