Skip to content

feat: Add ability to use Fargate Ephemeral Storage #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2021

Conversation

raizyr
Copy link
Contributor

@raizyr raizyr commented Oct 8, 2021

Description

Add the ability to use Fargate Ephemeral Storage

Motivation and Context

With multiple large plans being ran, it's possible to run the container out of disk space. This enables the use of Fargate's ephemeral storage option to reduce that chance.

Breaking Changes

None

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    Been running it successfully for a couple months.

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update versions.tf with aws provider version 3.45 in root and in examples. Also, please update documentation by running pre-commit run -a.

@antonbabenko antonbabenko changed the title Add ability to use ephemeral storage feat: Add ability to use Fargate Ephemeral Storage Oct 9, 2021
* Fix variables.tf formatting and update versions.tf files

* Update documentation
@raizyr raizyr requested a review from antonbabenko November 12, 2021 05:19
@raizyr
Copy link
Contributor Author

raizyr commented Nov 12, 2021

I missed that this had been reviewed for about a month, sorry for the delay. Requested changes have been made. 😄

@antonbabenko antonbabenko merged commit efa334e into terraform-aws-modules:master Nov 14, 2021
@antonbabenko
Copy link
Member

Thanks, @raizyr !

v3.5.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants