feat: Remove not used parameter atlantis_allowed_repo_names

[snovikov]

Description

One of the parameters is not used and could be removed.

Motivation and Context

• Remove variable which is actually not used in the module
• Remove variable which corresponds to obsolete atlantis configuration (see --repo-whitelist) in atlantis-docs

Breaking Changes

• This will remove input variable of main module atlantis_allowed_repo_names
• This will rename output of main module: atlantis_allowed_repo_names -> atlantis_repo_allowlist
• This will rename input varialbe of sub-modules: atlantis_allowed_repo_names -> atlantis_repo_allowlist

How Has This Been Tested?

• I have tested and validated these changes using one or more of the provided examples/* projects
• terraform plan in examples/github-complete

[bryantbiggs]

this variable is also used in the webhook sub-module - we will need to somehow accommodate that as well with this change otherwise it breaks the webhooks. even though atlantis doesn't use this param anymore, we still need to repo names for the webhooks

 # module.github_repository_webhook.github_repository_webhook.this[0] must be replaced
-/+ resource "github_repository_webhook" "this" {
      + etag       = (known after apply)
      ~ id         = "xxxxxxxxx" -> (known after apply)
      ~ repository = "scritchity-scratch" -> "github.com/clowdhaus/*" # forces replacement
      ~ url        = "https://api.github.com/repos/clowdhaus/scritchity-scratch/hooks/xxxxxxxxx" -> (known after apply)
        # (2 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

[snovikov]

@bryantbiggs thanks for your comment, but I think you are missing, that instead of atlantis_allowed_repo_names is removed, it is renamed to atlantis_repo_allowlist for consistency naming in submodules as well.

Please check this commit 3849654

Now both module and submodules are using the same naming and also the same list of repositories.

Is there any reason, that those two repository lists (white-list for atlantis + webhooked repositories) should be separated?

[bryantbiggs]

we can't completely remove this variable since we need it (or something similar) for creating the webhooks

[snovikov]

@bryantbiggs please read my comments. this parameter is not removed.

[snovikov]

Rebased to v3.8.0.

[antonbabenko]

This PR is included in version 3.9.0 🎉

[antonbabenko]

LGTM. I made this release as a minor (not patch) since it will replace a value in the outputs.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.